feat: Cmd+Enter to submit comments, Esc to close card#1
Open
nickmeinhold wants to merge 13 commits into
Open
Conversation
Add optional webhook functionality to notify external services when cards are created, updated, moved, or deleted. Configuration: - WEBHOOK_URL: URL to POST webhook payloads to - WEBHOOK_SECRET: Optional secret for HMAC signature verification Webhook payload includes: - Event type (card.created, card.updated, card.moved, card.deleted) - Card data (id, title, description, dueDate, listId, boardId) - User who performed the action - Changes object (for updates) showing old/new values The webhook is fire-and-forget (non-blocking) to avoid impacting API response times. Failures are logged but don't affect the main operation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com> Resolving branch conflicts
- Add 10s timeout to webhook fetch using AbortController - Fix dueDate type to string (reflects JSON serialization) - Remove email from user payload for privacy Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add database schema for per-workspace webhook configuration: - workspaceWebhooks table with url, secret, events, active fields - Foreign keys to workspace and user tables - Row-level security enabled Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add repository functions for workspace webhooks: - create, update, getByPublicId, hardDelete - getAllByWorkspaceId for listing - getActiveByWorkspaceId for sending webhooks Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add webhook router with endpoints: - list: Get all webhooks for workspace - create: Add new webhook - update: Modify webhook settings - delete: Remove webhook - test: Send test payload All endpoints require admin role. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Update card create/update/delete to send webhooks to all active workspace webhooks instead of just env var webhook. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add React components for webhook management: - WebhookList: Table with edit/test/delete actions - NewWebhookModal: Create/edit form with event checkboxes - DeleteWebhookConfirmation: Confirmation dialog Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add WebhookSettings page with modals - Add webhooks.tsx page route - Add Webhooks tab to settings navigation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove WEBHOOK_URL/WEBHOOK_SECRET env var fallback. Webhooks are now only configured via the database/UI. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add comprehensive test coverage for webhook functionality: - webhook.test.ts: Tests for createCardWebhookPayload, sendWebhookToUrl, and sendWebhooksForWorkspace utility functions - webhook.test.ts (router): Tests for list, create, update, delete, and test procedures including authorization checks Also adds vitest to @kan/api package for running tests. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
D3lK1ch1
force-pushed
the
feature/keyboard-shortcuts
branch
from
3e3b147 to
0daa859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onModEntercallback prop on theEditorcomponent and ahandleKeyDownhandler in editor propsuseKeyboardShortcutinfrastructure — respects modal state (won't fire if a modal is open) and input focus (won't fire when typing in inputs/contentEditable)Fixes kanbn#389, kanbn#390
Test plan
🤖 Generated with Claude Code