chore(frontend): refresh app launch assets - #407
Merged
LUPENGHAN merged 1 commit intoAug 28, 2026
Conversation
Contributor
There was a problem hiding this comment.
The review covers the Expo Android icon configuration and all changed launch/notification assets. The config parses successfully and git diff --check is clean, but the adaptive icon layer contract has two Android-facing regressions noted inline.
Additional findings
frontend/app.config.js:?: [P1] Use a transparent foreground-only adaptive icon asset: The newforegroundImageis the same full artwork as the replacement background and monochrome files: it contains an opaque beige rounded-square panel instead of only the transparent foreground artwork. Android/Expo composes this layer overbackgroundColorand then applies the launcher mask, so the embedded panel defeats the background/foreground separation and can be clipped into the wrong shape on launchers using circular or other masks. Export a foreground-only PNG with the artwork in the adaptive safe zone and transparent pixels elsewhere.
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更说明
android-icon-foreground-timeflow.pngsplash-icon.png影响范围
仅涉及 Expo 配置和前端图片资源,不包含业务逻辑、后端或数据库变更。
与 Issue 的关系
#403PR #409一起完成 Android 品牌图标资源统一的最终收口验证