feat: align admin monitoring and production usage observability - #181
Conversation
There was a problem hiding this comment.
The monitoring, usage reconciliation, telemetry compatibility, and frontend contract changes were reviewed. The admin test slice passes, and the web telemetry checks pass; the local web build could not be run because the workspace has no usable vite executable. One monitoring correctness regression is called out inline.
| double p95Current = queryPrometheus(p95Query("[24h]")) * 1000; | ||
| double p95Previous = queryPrometheus(p95Query("[24h] offset 24h")) * 1000; | ||
| GovernanceCounts counts = governanceCounts(); | ||
| Summary summary = new Summary("UP", queryPrometheus(apiErrorRateQuery()), |
There was a problem hiding this comment.
[P1] Preserve the Prometheus-backed backend health status
This hard-codes the summary status to UP, so the overview and OverviewPage will continue to show the backend as healthy even when Prometheus reports up == 0 or cannot be reached. The previous implementation derived this field from the up{instance="backend:8080"} metric, and the dashboard still uses this value to choose the normal/error state. Keep the health query (or an equivalent backend health check) here and report DOWN when it fails.
Summary
Validation