Skip to content

fix(backend): 完成单次行动的全部场景切换提案 - #525

Merged
Ximaohu-LMX merged 1 commit into
1024XEngineer:mainfrom
badadal:fix/524-scene-transition-finalization
Aug 29, 2026
Merged

fix(backend): 完成单次行动的全部场景切换提案#525
Ximaohu-LMX merged 1 commit into
1024XEngineer:mainfrom
badadal:fix/524-scene-transition-finalization

Conversation

@badadal

@badadal badadal commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

变更说明

  • 父行动叙事落库时,完成该行动下全部尚未标记的场景切换提案
  • 避免较早的 approved + narration_persisted=false 记录让房间永久停留在 processing
  • 保持操作幂等,并且不影响其他父行动的提案
  • 增加一次行动包含多条场景提案的回归测试

验证

  • uv run pytest tests/test_scene_transition_consent.py -q:18 passed
  • uv run pytest tests/test_scene_transition_consent.py tests/test_action_plan_turn_recovery.py tests/test_action_plan_persistence.py -q:53 passed
  • uv run ruff check app/service/scene_transition.py tests/test_scene_transition_consent.py:通过
  • 本地多人流程人工验证通过

Fixes #524

@badadal
badadal requested a review from Ximaohu-LMX August 29, 2026 17:01
@Ximaohu-LMX
Ximaohu-LMX merged commit 8deb5d8 into 1024XEngineer:main Aug 29, 2026
7 checks passed

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已检查固定 SHA 范围内的完整变更,重点覆盖场景提案收尾、父行动隔离、幂等重放,以及房间 processing 状态恢复链路。mark_narration_persisted 现在会在相同 room_id + parent_action_id 下收敛所有未完成提案,且不会触及其他父行动;调用方与新增回归测试的契约一致。

本地无法执行 PR 描述中的 pytest/ruff 命令,因为当前环境未安装 uvpytestruffgit diff --check 已通过。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug][Scene Transition] 单次行动连续换场景后房间永久停留在处理中

2 participants