Skip to content

feat(frontend)add derive-animation task post - #365

Merged
KurodaKayn merged 2 commits into
1024XEngineer:mainfrom
cqhasy:feat/frontend-derive-animation
Aug 28, 2026
Merged

feat(frontend)add derive-animation task post#365
KurodaKayn merged 2 commits into
1024XEngineer:mainfrom
cqhasy:feat/frontend-derive-animation

Conversation

@cqhasy

@cqhasy cqhasy commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Change Description

  • Adds a per-animation derive button in the sprite asset tree, allowing users to select missing directions and submit a derive_animation generation task.
  • Displays derived-animation tasks in the editor generation flow and treats their results as new animation candidates for review.

Implementation Approach

  • Adds a direction-selection popover beside each generated animation; already occupied directions in the same animation group are excluded.
  • Adds typed derive-animation request models, API client support, mutation handling, generated Core API typing, and generation-run resolution for derive_animation.
  • Adds English and Chinese editor translations plus UI/API/workspace test coverage.
  • The derive action is disabled for animations without generation metadata, when there are no missing directions, or while an animation request is pending.

Related Issue

Part of #345

Testing

  • cd frontend && pnpm format:check - passed.
  • cd frontend && pnpm lint - passed with one existing import(no-duplicates) warning in src/model/asset/record/types/asset-snapshot.ts.
  • cd frontend && pnpm test - passed: 113 test files and 600 tests.
  • cd frontend && pnpm build - passed (tsc -b && vite build).

Screenshots or Recordings

Not included.

Risks and Follow-ups

  • This PR only adapts the frontend to submit and display derive_animation tasks. Output quality issues in the derivation pipeline, such as non-symmetric generated directions or occasional green edges, are outside this frontend change and should be addressed separately.

Checklist

  • The PR is focused and does not include unrelated changes.
  • Asset names, formats, dimensions, and metadata follow project conventions.
  • Licensing and attribution information is included or unchanged as appropriate.
  • Documentation or examples were updated when needed.

@cqhasy
cqhasy requested a review from KurodaKayn August 28, 2026 06:21
@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holonic-asset Ready Ready Preview Aug 28, 2026 6:33am

@codecov

codecov Bot commented Aug 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
frontend 90.46% <100.00%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...tures/asset-editor/AssetTree/sprite-asset-tree.tsx 73.13% <100.00%> (ø)
.../src/features/asset-editor/use-editor-workspace.ts 94.56% <100.00%> (+1.14%) ⬆️
...d/src/model/asset/content/sprite-content.mapper.ts 97.80% <100.00%> (+0.10%) ⬆️
frontend/src/model/asset/types/asset.ts 100.00% <ø> (ø)
...l/generation/animation/animation-generation.api.ts 100.00% <100.00%> (ø)
...generation/animation/types/animation-generation.ts 100.00% <100.00%> (ø)
...rontend/src/model/generation/run/generation.api.ts 95.33% <100.00%> (+0.06%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@KurodaKayn

Copy link
Copy Markdown
Collaborator

@cqhasy enhance test cove

@cqhasy cqhasy added the type:feature A new capability or improvement to existing behavior. label Aug 28, 2026

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the complete fixed diff for the derive-animation flow, including direction-group filtering, request serialization, generation-run restoration, candidate merging, and editor review/apply behavior. The frontend request shape matches the Core derivation contract, and the changed paths are covered by the added tests.

Verification: repository diff checks passed. Automated frontend tests could not be rerun in this environment because the available Node.js is v20.20.2 while the configured pnpm 11.5.0 requires Node.js >=22.13 and imports node:sqlite.

View job run

@cqhasy
cqhasy requested a review from nighca August 28, 2026 08:02
@KurodaKayn
KurodaKayn merged commit a999692 into 1024XEngineer:main Aug 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature A new capability or improvement to existing behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants