Skip to content

feat(prompts): reinforce side-on flatness and user prompt priority in tileset - #357

Merged
cqhasy merged 5 commits into
1024XEngineer:mainfrom
JuhaoChen666:feat/tileset-side-on-flatness
Aug 28, 2026
Merged

feat(prompts): reinforce side-on flatness and user prompt priority in tileset#357
cqhasy merged 5 commits into
1024XEngineer:mainfrom
JuhaoChen666:feat/tileset-side-on-flatness

Conversation

@JuhaoChen666

Copy link
Copy Markdown
Contributor

Change Description (Required)

  • Reinforces Side-On perspective constraints in tileset generation to ensure pure 2D orthographic side elevation without pseudo-3D or pseudo-top-down top surfaces on blocks.
  • Strengthens user requirement priority so that explicit user instructions (e.g. requesting a flat tileset) always take precedence over default perspective or project metadata settings.

Implementation Approach (Required)

  • Updated tileSetItemTemplate, tileSetEditTemplate, and tileSetItemEditTemplate in prompts/tileset.go:
    • Added USER REQUIREMENT PRIORITY section establishing that explicit user creative briefs and item descriptions have top priority over default perspective interpretations.
    • Added dedicated PERSPECTIVE & CAMERA RULES with strict SIDE-ON / FLAT PERSPECTIVE RULES forbidding visible top planes, pseudo-3D slopes, or angled tilt.
  • Added comprehensive unit tests in prompts/tileset_test.go covering Side-On flatness and user requirement priority across item creation, tile editing, and item editing prompts.
  • Added real end-to-end live integration test in executor_tileset_live_test.go (TestLiveSideOnFlatTilesetGeneration) verifying actual model generation output under Side-On perspective.

Related Issue (Required)

None

Testing (Required)

  • go test -v ./internal/module/generator/prompts/... -run "TestTileSet" - PASS
  • go test -v ./internal/module/generator -run "TestProcessTileSet|TestTileSet" - PASS
  • HOLONIC_LLM_INTEGRATION=1 go test -v ./internal/module/generator -run TestLiveSideOnFlatTilesetGeneration -timeout 10m - PASS (real generation succeeded in 25.89s)

Screenshots or Recordings (Optional)

Not included.

Risks and Follow-ups (Optional)

None identified.

Checklist (Required)

  • The PR is focused and does not include unrelated changes.
  • Asset names, formats, dimensions, and metadata follow project conventions.
  • Licensing and attribution information is included or unchanged as appropriate.
  • Documentation or examples were updated when needed.

… tileset

When generating tilesets under side-on perspective, models could introduce pseudo-3D or pseudo-top-down top surfaces on blocks.

Add strict side-on flatness rules requiring pure 2D orthographic side elevation, and enforce top priority for explicit user perspective instructions.

Ensures side-on tilesets remain strictly flat and user creative requirements always override default perspective assumptions.
Verify real end-to-end model generation under side-on perspective with prompt flatness rules.

Saves generated composite and raw image artifacts for visual verification.

Ensures side-on live generation completes without errors.
@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
holonic-asset Ignored Ignored Preview Aug 28, 2026 6:48am

@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
backend 90.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...e-api/internal/module/generator/prompts/tileset.go 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fennoai fennoai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The prompt changes consistently carry the explicit user brief through creation and edit flows, and the focused generator test suite passes. The new live test has one portability issue noted inline.

Verification: go test ./internal/module/generator/... and git diff --check passed.

Comment thread core-api/internal/module/generator/executor_tileset_live_test.go Outdated
@JuhaoChen666
JuhaoChen666 requested a review from cqhasy August 28, 2026 02:15
The side-on live test wrote artifacts to an author-specific path and ignored failures.

Use a test-owned temporary directory and fail on preview encoding, decoding, or file writes.

Keep the live test portable and prevent false success when artifacts cannot be saved.
@cqhasy
cqhasy merged commit 3f435ba into 1024XEngineer:main Aug 28, 2026
7 checks passed
@JuhaoChen666
JuhaoChen666 deleted the feat/tileset-side-on-flatness branch August 28, 2026 08:12
@JuhaoChen666 JuhaoChen666 self-assigned this Aug 28, 2026
@JuhaoChen666 JuhaoChen666 added type:feature A new capability or improvement to existing behavior. area:generation Asset generation flows, pipelines, post-generation. labels Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:generation Asset generation flows, pipelines, post-generation. type:feature A new capability or improvement to existing behavior.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants