PE-8082 githubbot: immediate working reaction on owned-PR management turns - #17
Draft
oponder wants to merge 1 commit into
Draft
PE-8082 githubbot: immediate working reaction on owned-PR management turns#17oponder wants to merge 1 commit into
oponder wants to merge 1 commit into
Conversation
…n (PE-8082) Review-request and issue-work turns already ack instantly (eyes on the subject, settled to rocket/confused when the turn finishes), but owned-PR management turns — address-review, CI-fix, conflict resolution — gave no signal until the agent pushed or replied. A reviewer leaving feedback on a bot-owned PR saw silence while the turn ran. Fire the same subject-reaction lifecycle from fireManagementTurn, the choke point all management turns flow through: eyes before the turn starts (not awaited, so the ack can't delay the turn), settled in the background chain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PE-8082: when gerard is asked for a review it reacts immediately, but when it responds to review feedback on a PR it owns there is no activity until it pushes or replies.
Review-request (
review.ts), issue-work (issue-manager.ts), and @-mention (index.ts) turns all ack instantly; owned-PR management turns (pr-manager.ts: address-review, CI-fix, conflict resolution) were the one silent path. This adds the same 👀 → 🚀/😕 subject-reaction lifecycle tofireManagementTurn, the choke point all management turns flow through, reusing the existingreactWorkingOnSubject/settleSubjectReactionhelpers. The ack is fired without awaiting so it lands before the sandbox turn starts, and a failed reaction never blocks the turn.Reactions land on the PR itself rather than the triggering review because the REST reactions API has no endpoint for review bodies — this matches what review-request turns already do.
Testing
pnpm --filter githubbot test— 79 pass (2 new: eyes ack + settle on a changes-requested review; no reaction on the approved/merge path).pnpm --filter githubbot run check:types— clean.Deploy notes
centaur-githubbotimage changes. It must be rebuilt + imported on the cluster box via deploy-centaur after merge (no registry on the box), then the deployment restarted.mainis currently tree-identical to upstreamparadigmxyz/centaur; merging this diverges it. Recommend upstreaming this patch so a future fork sync doesn't drop it.🤖 Generated with Claude Code