bridge: persist per-thread collaboration mode - #220
Draft
0xSero wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
The queued Mobile CI run was intentionally canceled to give the merge-blocking clean-runner #221 gate the next available slot. #220 already has a green local 790-test Rust suite, generated Android compile/tests, and clean iOS simulator build, and it remains draft for installed kill/relaunch acceptance. Rerun Mobile CI when that physical acceptance is ready; the cancellation is scheduling, not a test failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
thread_modes.jsonAppStoremethodRoot cause
The pinned app-server protocol's authoritative
Threaddata returned by list/read/resume does not expose collaboration mode.ThreadSnapshot::from_infotherefore rebuilt every process-cold thread in Default mode, while live Plan-item handling only changed reducer memory. Process death lost both that mode and the transient implement-plan prompt.Validation
cargo test --manifest-path shared/rust-bridge/Cargo.toml -p codex-mobile-client --lib— 790 passed, 5 ignoredsetThreadModePersistenceDirectoryon both surfaces:app:compileDebugKotlin :app:testDebugUnitTest— BUILD SUCCESSFULmake ios-sim-fast— BUILD SUCCEEDEDxcodebuild ... build— BUILD SUCCEEDEDgit diff --check origin/main...HEAD— passedFocused tests cover Default removing the durable entry, restart restoration, Plan-item auto-detection persistence, cold implement-prompt reconstruction, dismissed-prompt preservation on ordinary refresh, later-user-turn suppression, and the 512-entry storage bound.
Known acceptance gap
This remains a bounded mobile fallback because upstream cannot round-trip collaboration mode today. It cannot observe a mode change made by another client, and a thread will not match its local entry if the same server is later registered under a different
server_id. An authoritative upstream thread field should supersede the local fallback when available.This PR stays draft until an installed iOS/Android app is killed and relaunched against a live Plan-mode thread to confirm the full cold-relaunch UX.
Closes #100