ssh: import Fish and Nix profile paths - #216
Draft
0xSero wants to merge 1 commit into
Draft
Conversation
Owner
Author
|
The remaining Mobile CI run was intentionally canceled after shared-prep and Android passed, to prioritize #221's clean-runner test-hermeticity gate. #216 already has 778 green Rust tests, focused shell/SSH tests, and remains draft for a real Fish/NixOS host. Rerun the platform matrix with that live-host acceptance before readiness; this cancellation is scheduling, not a failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the shell-environment portion of #185.
Root cause
Litter executes generated SSH commands under POSIX
sh, but its profile importer only tried POSIX/bash/zsh files. A Fish login account—and common NixOS/profile locations—could therefore hidecodex, Node, and package-manager binaries from the SSH command environment.Change
shfish --login --commandonly to export PATH through a sentinel-safe recordVerification
/bin/sh -ncodex-mobile-clientlib suite: 778 passed, 0 failed, 5 live-only ignoredgit diff --checkRemaining acceptance
No real Fish/NixOS SSH host was available; Fish behavior was exercised through an executable fixture. Keep this draft until a live Fish host proves Codex/package-manager lookup. The reporter's folder-picker
-32604is a distinct app-server spawn path and is not claimed fixed without host diagnostics.