fix(network-monitor): move local proving off async runtime#2136
Open
Ollie202 wants to merge 1 commit into
Open
fix(network-monitor): move local proving off async runtime#2136Ollie202 wants to merge 1 commit into
Ollie202 wants to merge 1 commit into
Conversation
| let proven_tx = prover.prove(executed_tx).await.context("Failed to prove transaction")?; | ||
| let account_id = counter_account.id(); | ||
| let handle = tokio::runtime::Handle::current(); | ||
| let (proven_tx, transaction_inputs) = spawn_blocking_in_current_span(move || { |
Collaborator
There was a problem hiding this comment.
considering that this shouldn't be called regularly, maybe we can omit spawn blocking here
| - [BREAKING] Removed `CheckNullifiers` endpoint ([#2049](https://github.com/0xMiden/node/pull/2049)). | ||
| - Replaced blocking-in-async operations in the validator, remote prover, and ntx-builder with `spawn_blocking` to avoid starving the Tokio runtime ([#2041](https://github.com/0xMiden/node/pull/2041)). | ||
| - Replaced local store block proving with `spawn_blocking` to avoid starving the Tokio runtime ([#1976](https://github.com/0xMiden/node/issues/1976)). | ||
| - Replaced local network monitor transaction execution and proving with `spawn_blocking` to avoid starving the Tokio runtime ([#1976](https://github.com/0xMiden/node/issues/1976)). |
Collaborator
There was a problem hiding this comment.
I don't think thadt this change requires a changelog entry
Ollie202
force-pushed
the
fix/network-monitor-blocking-work
branch
from
53b4ea4 to
ce36808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially addresses #1976.
Problem
The network monitor still performs local transaction execution and proof generation directly from async code in two places:
Both paths can run CPU-heavy VM/prover work without yielding, which can starve Tokio worker threads while the monitor is running.
Changes
spawn_blocking_in_current_span.spawn_blocking_in_current_span.CloneforMonitorDataStoreso the blocking task owns a fresh in-memory datastore and can rebuild its MAST store from the loaded accounts.Testing
cargo +nightly fmt --check --allgit diff --checkI also tried
cargo check -p miden-network-monitor, but it stops before compiling on Windows because the current protocol dependency pulls an AggLayer submodule file with:in the filename:tools/addRollupType/addRollupMainnet10/add_rollup_type_10_output-2025-03-11T15:54:21.263Z.json