docs(crypto): fix dangling reference to deleted hash-poseidon.ts#48
Merged
Conversation
poseidon.rs's domain_tag doc pointed at packages/sdk/src/hash-poseidon.ts, which Phase 3 (#37) deleted — the TS side now calls this crate's domain_tag through the crypto-wasm binding. Reword to reference the WASM binding instead. Comment-only. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup after the ZK-friendly migration. While auditing the repo for residual legacy artifacts, found one dangling doc reference:
crates/crypto/src/poseidon.rs'sdomain_tagcomment pointed atpackages/sdk/src/hash-poseidon.ts, which Phase 3 (#37) deleted. The TS side now computes the same domain tag through thecrypto-wasmdomain_tagbinding (this crate compiled to WASM). Reworded the comment accordingly.Comment-only;
cargo check -p cryptoclean.Audit result
This was the only dangling reference left. A repo-wide sweep confirms no other references to any deleted file (suite-x25519*, suites*, encrypt*, envelope-unified, envelope-codec, hash-poseidon, the 6 legacy specs, wallet-derived-keys, import-env-keys). The remaining
ChaCha20(babyjub-cipher.md) andBlake2b/HKDF(poseidon/kdf specs + source) matches are current-design references — rationale prose and the live domain-tag primitive — not legacy.[agent PR]