🎨 Palette: Make OSINT modal triggers accessible to keyboard users#124
Conversation
Added role="button" and aria-haspopup="dialog" to OSINT <a> tags, and implemented Spacebar key support in modal.js to improve accessibility for keyboard-only and screen reader users. Also logged the learning in .Jules/palette.md.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What: The "OSINT" links that trigger a modal have been updated to act more like native buttons. They now have
role="button"andaria-haspopup="dialog"attributes, and akeydownevent listener was added tomodal.jsto respond to theSpacebarkey.🎯 Why: Previously, these triggers were standard anchor (
<a>) tags withhref="#". When users navigating via keyboard attempted to activate them using theSpacebar(the standard key for buttons), the page would scroll down instead of opening the modal. Screen readers also announced them as links instead of buttons that open dialogs.📸 Before/After: N/A (Visual appearance is unchanged, behavioral difference only).
♿ Accessibility:
role="button"to inform assistive tech that the link behaves as a button.aria-haspopup="dialog"to set expectations that a modal will appear.SpacebarandSpacekeydown events toopenModal, callinge.preventDefault()to stop unwanted page scrolling and providing true feature parity with native<button>elements.PR created automatically by Jules for task 2092491123866685564 started by @0m364