diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index d88ad10..18cd3ea 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,4 +1,4 @@ # Default reviewers for every change in this repo. -# Outside contributors: fork the repo and open a PR against the default branch — +# Outside contributors: fork the repo and open a PR against the default branch, # you do NOT need write access. A code owner below must approve before merge. * @zerp-pk/maintainers diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 8659348..f956764 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -32,5 +32,5 @@ participating, you agree to abide by it. ## Security issues -Do not report security vulnerabilities via public issues — see +Do not report security vulnerabilities via public issues - see [SECURITY.md](SECURITY.md). diff --git a/README.md b/README.md index 7d4d96d..fb5c239 100644 --- a/README.md +++ b/README.md @@ -13,13 +13,13 @@ CRM module for the [Zerp](https://github.com/zerp-pk) ERP platform. CRM and lead composer require zerp/lead ``` -The package auto-registers via Laravel's package discovery — no manual service provider registration needed. +The package auto-registers via Laravel's package discovery - no manual service provider registration needed. ## What it provides -- `Zerp\Lead\Providers\LeadServiceProvider` — boots this module's routes, migrations, and settings +- `Zerp\Lead\Providers\LeadServiceProvider` - boots this module's routes, migrations, and settings - Frontend pages/components under `src/Resources/js` ## License -MIT — see [LICENSE](LICENSE). +MIT - see [LICENSE](LICENSE). diff --git a/src/Resources/js/Pages/Reports/DealReports.tsx b/src/Resources/js/Pages/Reports/DealReports.tsx index d1a126f..a13800c 100644 --- a/src/Resources/js/Pages/Reports/DealReports.tsx +++ b/src/Resources/js/Pages/Reports/DealReports.tsx @@ -102,7 +102,7 @@ export default function DealReports() {

{t('Win Rate')}

- {winLoss?.win_rate === null || winLoss?.win_rate === undefined ? '—' : `${winLoss.win_rate}%`} + {winLoss?.win_rate === null || winLoss?.win_rate === undefined ? '-' : `${winLoss.win_rate}%`}

diff --git a/src/Resources/js/utils/forecast.mjs b/src/Resources/js/utils/forecast.mjs index f719c26..7d1f33d 100644 --- a/src/Resources/js/utils/forecast.mjs +++ b/src/Resources/js/utils/forecast.mjs @@ -5,7 +5,7 @@ // // Probability is stage-driven (0–100). Records with a null/blank price count 0. // Pure module (no imports) so it bundles cleanly into the browser build. -// Self-check lives in forecast.selfcheck.mjs — run `node forecast.selfcheck.mjs`. +// Self-check lives in forecast.selfcheck.mjs - run `node forecast.selfcheck.mjs`. export function stageRevenue(records) { return (records || []).reduce((sum, r) => sum + (Number(r?.price) || 0), 0); diff --git a/src/Support/LeadScoring.php b/src/Support/LeadScoring.php index 7d8e60f..397d90c 100644 --- a/src/Support/LeadScoring.php +++ b/src/Support/LeadScoring.php @@ -12,7 +12,7 @@ * sum of matched rule points, normalized to 0–100 against the maximum achievable * (sum of all active rule points). Signals include both lead attributes and * engagement (activity/call counts), so the stored score must be recomputed - * whenever any of those change — see recompute()/recomputeAll() call sites. + * whenever any of those change - see recompute()/recomputeAll() call sites. */ class LeadScoring { @@ -38,7 +38,7 @@ class LeadScoring /** * Pure evaluator. $signals: [field => scalar|array]. $rules: array of * ['field','operator','value','points']. Returns total/max/percent. - * No DB, no models — this is the unit under test. + * No DB, no models - this is the unit under test. */ public static function evaluate(array $signals, array $rules): array { @@ -113,7 +113,7 @@ public static function recompute(Lead $lead): void /** * Recompute every lead for a creator. Triggered when rules change. - * ponytail: O(leads) with per-lead count queries; fine at SMB scale — move + * ponytail: O(leads) with per-lead count queries; fine at SMB scale - move * to a queued job with grouped counts if lead volume grows large. */ public static function recomputeAll(int $creatorId): void diff --git a/src/Support/leadscoring_selfcheck.php b/src/Support/leadscoring_selfcheck.php index a8dea3f..885b3f3 100644 --- a/src/Support/leadscoring_selfcheck.php +++ b/src/Support/leadscoring_selfcheck.php @@ -10,7 +10,7 @@ function check(string $label, $actual, $expected): void { global $failures; if ($actual !== $expected) { - fwrite(STDERR, "FAIL: $label — got " . var_export($actual, true) . ", expected " . var_export($expected, true) . "\n"); + fwrite(STDERR, "FAIL: $label - got " . var_export($actual, true) . ", expected " . var_export($expected, true) . "\n"); $failures++; } }