From 55ff12cd816d33bef0fb0e13b88e732651d91c94 Mon Sep 17 00:00:00 2001
From: Tim Wojtulewicz <tim@corelight.com>
Date: Mon, 1 Jun 2026 08:53:49 -0700
Subject: [PATCH] Mark unstable tests as failures in JUnit output

The JUnit format only has tags for faiulre, error, and skipped. Our
unofficial unstable tag causes problems with other tooling that reads
the JUnit output, such as CircleCI's test insights.
---
 btest | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/btest b/btest
index 1d32c00..01c9ea9 100755
--- a/btest
+++ b/btest
@@ -2169,7 +2169,6 @@ class XMLReport(OutputHandler):
     RESULT_PASS = "pass"
     RESULT_FAIL = "failure"
     RESULT_SKIP = "skipped"
-    RESULT_UNSTABLE = "unstable"
 
     def __init__(self, options, xmlfile):
         """Output handler for producing an XML report of test results.
@@ -2252,7 +2251,8 @@ class XMLReport(OutputHandler):
         self.addTestResult(test, self.RESULT_FAIL)
 
     def testUnstable(self, test, msg):
-        self.addTestResult(test, self.RESULT_UNSTABLE)
+        # JUnit has no concept of flaky tests, report them as failures.
+        self.testFailed(test, msg)
 
     def testSkipped(self, test, msg):
         self.addTestResult(test, self.RESULT_SKIP)