Skip to content

BackupSaves skips saves when a game has no options files #2

Description

@zalgebar

Bug

GameBackupSystem/GameBackups.cs (~line 91):

private void BackupSaves(string baseBackupFolder, bool overwriteFiles)
{
    if (SavesFolders == null || OptionsFiles.Count < 1) return;   // wrong list

BackupSaves returns early when there are no options files, so a game
configured with save folders but no options file never gets its saves backed
up
. It also throws a NullReferenceException if OptionsFiles is null (it
null-checks SavesFolders but then dereferences OptionsFiles).

Fix

Guard on the list the method actually uses:

if (SavesFolders == null || SavesFolders.Count < 1) return;

Severity

Data-protection: silent failure to back up saves — the tool's core job.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions