Merge pull request godotengine#113380 from aaronfranke/range-no-big-min

Repiteo · Repiteo · commit 8dbf8a89910e · 2026-06-30T14:49:58.000-05:00
Range: Don't use min for snap offset when it's too big
diff --git a/scene/gui/range.cpp b/scene/gui/range.cpp
@@ -189,8 +189,13 @@ double Range::_calc_value(double p_val, double p_step) const {
 	}
 
 	if (p_step > 0) {
-		// Subtract min to support cases like min = 0.1, step = 0.2, snaps to 0.1, 0.3, 0.5, etc.
-		p_val = _snapped_r128(p_val - shared->min, p_step) + shared->min;
+		if (Math::abs(shared->min) > p_step * 1e14) {
+			// Min is too big to use for snapping offset, so snap without it.
+			p_val = _snapped_r128(p_val, p_step);
+		} else {
+			// Subtract min to support cases like min = 0.1, step = 0.2, snaps to 0.1, 0.3, 0.5, etc.
+			p_val = _snapped_r128(p_val - shared->min, p_step) + shared->min;
+		}
 	}
 
 	if (_rounded_values) {

Original file line number	Diff line number	Diff line change
`@@ -189,8 +189,13 @@ double Range::_calc_value(double p_val, double p_step) const {`
`189`	`189`	`}`
`190`	`190`
`191`	`191`	`if (p_step > 0) {`
`192`		`- // Subtract min to support cases like min = 0.1, step = 0.2, snaps to 0.1, 0.3, 0.5, etc.`
`193`		`- p_val = _snapped_r128(p_val - shared->min, p_step) + shared->min;`
	`192`	`+ if (Math::abs(shared->min) > p_step * 1e14) {`
	`193`	`+ // Min is too big to use for snapping offset, so snap without it.`
	`194`	`+ p_val = _snapped_r128(p_val, p_step);`
	`195`	`+ } else {`
	`196`	`+ // Subtract min to support cases like min = 0.1, step = 0.2, snaps to 0.1, 0.3, 0.5, etc.`
	`197`	`+ p_val = _snapped_r128(p_val - shared->min, p_step) + shared->min;`
	`198`	`+ }`
`194`	`199`	`}`
`195`	`200`
`196`	`201`	`if (_rounded_values) {`