Skip to content

Comment ending in ---> causes parser to skip following nodes #58

Description

@NightEule5

I encountered an issue where parsing breaks after a comment ending in ---> instead of the usual -->:

use tl::{parse, ParserOptions};

fn main() {
    let dom = parse(r#"
        <div class="ok"></div>
        <!-- Comment with extra hyphen >--->
        <div class="unreachable"></div>
    "#, ParserOptions::default()).unwrap();

    dom.get_elements_by_class_name("ok").next().expect(".ok node");

    dom.get_elements_by_class_name("unreachable").next().expect(".unreachable node");
}

Printing the DOM:

VDom {
    parser: Parser {
        stream: Stream { ... },
        stack: [],
        options: ParserOptions {
            flags: 0,
        },
        tags: [
            Raw(
                Bytes(
                    "\n        ",
                ),
            ),
            Tag(
                HTMLTag {
                    _name: Bytes(
                        "div",
                    ),
                    _attributes: Attributes {
                        raw: InlineHashMap(
                            InlineHashMap<0 items>,
                        ),
                        id: None,
                        class: Some(
                            Bytes(
                                "ok",
                            ),
                        ),
                    },
                    _children: InlineVec(
                        InlineVec<0 items>,
                    ),
                    _raw: Bytes(
                        "<div class=\"ok\"></div>",
                    ),
                },
            ),
            Raw(
                Bytes(
                    "\n        ",
                ),
            ),
            Comment(
                Bytes(
                    "",
                ),
            ),
        ],
        ast: [
            NodeHandle(
                0,
            ),
            NodeHandle(
                1,
            ),
            NodeHandle(
                2,
            ),
            NodeHandle(
                3,
            ),
        ],
        ids: {},
        classes: {},
        version: None,
    },
}

The last node is the comment, and it's parsed as if it's empty. Removing the extra dash produces the expected result

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions