Viewer improvements for faster rendering complex ifc models

[jbaan]

We have done several changes in c++ webgl part to have better viewer performance.

[jbaan]

fps-xbim-web-ui-dist.zip

[andyward]

Hi @jbaan Thanks for contributing. I had a quick look at the zip and couldn't determine any significant changes - it just seems to be mainly typescript definition files. Can you check?

Rather than share zip files, probably the best way to share what you've done is to create a pull request so we can integrate the changes.

BTW - technically I assume you have changed the shader code (GLSL) rather than C++

[jbaan]

We have created a patch file which includes all changes:

FpsXbimWebUI-838f236-Implement Instanced rendering.patch

[andyward]

Thanks for this. Wow - this is a big patch! Given the amount of change I feel this really needs a PR not a patch. This is what Im seeing:

 .github/ISSUE_TEMPLATE.md                     |   17 -
 .vscode/launch.json                           |   37 -
 package-lock.json                             | 8037 ++++++++++++++++-
 src/common/product-map.ts                     |  101 +-
 src/model-handle.ts                           |  510 +-
 src/model-pointers.ts                         |   29 +-
 src/plugins/Grid/{vshader.c => vshader.glsl}  |    0
 .../{cube_fshader.c => cube_fshader.glsl}     |    0
 .../{cube_vshader.c => cube_vshader.glsl}     |    0
 src/reader/InstanceData.ts                    |  615 ++
 src/reader/model-geometry.ts                  |  572 +-
 src/reader/triangulated-shape.ts              |   40 +-
 ...nt_shader.c => depth_fragment_shader.glsl} |    0
 ...rtex_shader.c => depth_vertex_shader.glsl} |    0
 ...fragment_shader.c => fragment_shader.glsl} |    0
 ..._shader_300.c => fragment_shader_300.glsl} |    0
 src/shaders/{phong.c => phong.glsl}           |    0
 .../{vertex_shader.c => vertex_shader.glsl}   |   92 +-
 src/shaders/vertex_shader.ts                  |    2 +-
 ...ex_shader_300.c => vertex_shader_300.glsl} |   93 +-
 src/shaders/vertex_shader_300.ts              |    2 +-
 src/viewer.ts                                 |   10 +-
 src/workers/geometry-loader.ts                |    2 +-
 src/workers/worker.ts                         |    2 +-
 utilities/shader-compiler.js                  |    6 +-
 25 files changed, 9452 insertions(+), 715 deletions(-)
 delete mode 100644 .github/ISSUE_TEMPLATE.md
 delete mode 100644 .vscode/launch.json
 rename src/plugins/Grid/{vshader.c => vshader.glsl} (100%)
 rename src/plugins/NavigationCube/{cube_fshader.c => cube_fshader.glsl} (100%)
 rename src/plugins/NavigationCube/{cube_vshader.c => cube_vshader.glsl} (100%)
 create mode 100644 src/reader/InstanceData.ts
 rename src/shaders/{depth_fragment_shader.c => depth_fragment_shader.glsl} (100%)
 rename src/shaders/{depth_vertex_shader.c => depth_vertex_shader.glsl} (100%)
 rename src/shaders/{fragment_shader.c => fragment_shader.glsl} (100%)
 rename src/shaders/{fragment_shader_300.c => fragment_shader_300.glsl} (100%)
 rename src/shaders/{phong.c => phong.glsl} (100%)
 rename src/shaders/{vertex_shader.c => vertex_shader.glsl} (65%)
 rename src/shaders/{vertex_shader_300.c => vertex_shader_300.glsl} (65%)

There's clearly a lot going on in these changes (beyond just optimisation) and a PR will let us review the changes more granularly.

Unfortunately I can't even apply this patch since it's not based off any recent master commit that I can identify.

git apply --check ..\FpsXbimWebUI-838f236-Implement.Instanced.rendering.patch
error: patch failed: .vscode/launch.json:1
error: .vscode/launch.json: patch does not apply
error: patch failed: package-lock.json:1
error: package-lock.json: patch does not apply
error: patch failed: src/model-handle.ts:4
error: src/model-handle.ts: patch does not apply
error: patch failed: src/reader/model-geometry.ts:4
error: src/reader/model-geometry.ts: patch does not apply
error: patch failed: src/shaders/vertex_shader.c:193
error: src/shaders/vertex_shader.c: patch does not apply
error: patch failed: src/shaders/vertex_shader.ts:1
error: src/shaders/vertex_shader.ts: patch does not apply
error: patch failed: src/shaders/vertex_shader_300.c:106
error: src/shaders/vertex_shader_300.c: patch does not apply
error: patch failed: src/shaders/vertex_shader_300.ts:1
error: src/shaders/vertex_shader_300.ts: patch does not apply
error: patch failed: src/workers/worker.ts:1
error: src/workers/worker.ts: patch does not apply

I managed to recover some of the changes (but it won't compile). But just based on that I'm also not sure why you're:

1. deleting the Github Issue template, launch.json
2. renaming the shader files to .glsl
3. making such a fundamental re-architecture (e.g. to model-handle and the shaders)

We'd like to take this improvement given you've clearly spent time on this, but given the scale of the changes could you:

• provide as a formal Pull Request (off master) so we can see commits & what has changed
• provide a bit of an explanation as to what you've done & why - e.g. kind of performance improvements you've seen as a result

Thanks