When exporting from Andor Solis native .sif format to the .asc format that WrightTools expects, comments within the from_Solis method advise users to opt-in to appending the acquisition attributes to the file. When you elect to do so, Andor Solis asks for whether they should be appended to the top or bottom of the file. Our current WrightTools.data.from_Solis expects data at the top, and checks for attrs at the bottom. The method fails if the attrs are instead appended at the top of the file.
Given that the top vs bottom choice is arbitrary, and top is at least the default in the current version of Andor Solis I am using, it would be nice to allow for both export formats. We could make this an argument of the method (default can be bottom to maintain previous methods), or since the formatting of the attrs is different from the data, we could build in a check to automatically determine whether data or attrs is listed first, treating accordingly.
When exporting from Andor Solis native .sif format to the .asc format that WrightTools expects, comments within the from_Solis method advise users to opt-in to appending the acquisition attributes to the file. When you elect to do so, Andor Solis asks for whether they should be appended to the top or bottom of the file. Our current WrightTools.data.from_Solis expects data at the top, and checks for attrs at the bottom. The method fails if the attrs are instead appended at the top of the file.
Given that the top vs bottom choice is arbitrary, and top is at least the default in the current version of Andor Solis I am using, it would be nice to allow for both export formats. We could make this an argument of the method (default can be bottom to maintain previous methods), or since the formatting of the attrs is different from the data, we could build in a check to automatically determine whether data or attrs is listed first, treating accordingly.