fetch() caches previous responses, returns bad results

[kabirsikand]

When an array is returned from a fetch() call, any consecutive fetch() calls use the same (cached) array as a response, overwrite it with any incoming indices, and returns the resulted array to the caller.
e.g.

some_link_resource.fetch() ->
network response: [ object1, object2, object3, object4 ]
fetch results: [ object1, object2, object3, object4 ]

some_other_link_resource.fetch() ->
network response: [ object5, object6 ]
fetch results: [ object5, object6, object3, object4 ]

some_third_link_resource.fetch() ->
network response: [ ]
fetch results: [ object5, object6, object3, object4 ]

[passy]

See under the "Links" section: https://weluse.github.io/hyperagent/:

By default, fetch() only requests the resource once from the server and directly returns a promise on the cached result on successive calls. If you want to force a refresh from the server, you can set the force flag in an options object:

root.links['ht:users'].fetch().then(...);

// Enforce a refresh.
root.links['ht:users'].fetch({ force: true }).then(...);

[kabirsikand]

Even when a refresh is forced on the fetch call, the results are cached in the case of array results. The example I provided can be mimicked with the force option set below:

## should return 4 results
some_link_resource.fetch({force:true}) ->
network response: [ object1, object2, object3, object4 ]
fetch results: [ object1, object2, object3, object4 ]

## should return 2 results
some_other_link_resource.fetch({force:true}) ->
network response: [ object5, object6 ]
fetch results: [ object5, object6, object3, object4 ]

## should return an empty array
some_third_link_resource.fetch({force:true}) ->
network response: [ ]
fetch results: [ object5, object6, object3, object4 ]

Again, the fact that network calls are being sent out and received shows that the links should not be caching previous results, since the links are each separate calls, not successive calls on the same link resource. The {force:true} option need not even be set in this case.

However, in the case of pure object responses, the behavior is as expected.

some_object_link_resource.fetch({force:true}) ->
network response: { key1: object1, key2: object2, key3: object3 }
fetch results: { key1: object1, key2: object2, key3: object3 }

some_other_object_link_resource.fetch({force:true}) ->
network response: { key1: object1, key2: object2 }
fetch results: { key1: object1, key2: object2 }

some_third_object_link_resource.fetch({force:true}) ->
network response: { }
fetch results: { }

[kabirsikand]

I suggest reopening this.