Skip to content

fix(auth): bundled data-connect auth/device fixes#111

Open
tnunamak wants to merge 5 commits into
developfrom
tim/data-connect-auth-fixes
Open

fix(auth): bundled data-connect auth/device fixes#111
tnunamak wants to merge 5 commits into
developfrom
tim/data-connect-auth-fixes

Conversation

@tnunamak
Copy link
Copy Markdown
Member

@tnunamak tnunamak commented May 5, 2026

Summary

  • Surface Vana Personal Server URL discovery gaps instead of silently logging them.
  • Retry delivery of saved exports in remote mode without re-collecting data.
  • Serialize Vana refresh-token rotation and gate duplicate per-run delivery across retry and fresh-export paths.
  • Clarify import history copy: Sync -> Collect again.

Verification

  • npm test -- src/hooks/useEvents.test.ts src/pages/settings/sections/imports/components/import-history-row.test.tsx --run
  • npx prettier --check src/hooks/useEvents.ts src/hooks/useEvents.test.ts src/hooks/useVanaLogin.ts src/pages/settings/components/settings-server-mode.tsx src/pages/settings/sections/imports/components/import-history-row-actions.tsx

Note: local test discovery also picked up existing .claude/worktrees test copies; all passed.

tnunamak added 2 commits May 5, 2026 15:22
When the Tauri opener plugin call fails silently (e.g., dev web build,
permission denied, or first-tab race), the verification URL was
rendered as plain text and users had to copy/paste it. Make it a
button that calls plugin:opener|open_url on click and falls back to
window.open if the plugin isn't reachable.
Hydra's device-code flow now requests audience=vana-personal-server
instead of being audience-less (or, in the planned migration, the
user's per-PS URL). PS-side gates by validating this audience plus a
wallet-ownership check on the token subject. Hydra's data-connect
client whitelist must include this audience.
@tnunamak tnunamak changed the base branch from main to develop May 6, 2026 02:22
@tnunamak
Copy link
Copy Markdown
Member Author

tnunamak commented May 7, 2026

Follow-up pushed in 8e1f06a:\n\n- Stabilizes the app shell so html/body/#root stay fixed-height and only

scrolls. This avoids document-level focus correction when inputs receive/lose focus.\n- Removes global smooth scrolling from the base document to avoid animated focus-scroll jumps.\n- Restores native/subpixel font smoothing for crisper text rendering.\n\nVerification:\n- npm run build\n- git diff --check\n- Headless Chrome smoke: focusing an input inside changed only main.scrollTop; window/html/body/#root/main dimensions stayed stable and document scrollY remained 0.\n\nNote: npm run lint still fails before linting due the existing ESLint 9 flat-config extends issue.

@tnunamak
Copy link
Copy Markdown
Member Author

tnunamak commented May 7, 2026

Reverted the accidental UI-shell follow-up in a2757b7. This removes the focus/blur and font-smoothing changes from 8e1f06a and keeps the PR focused on the auth/device fixes.\n\nVerification: git diff --check HEAD~1..HEAD passed. Existing unrelated local connectors/lock.json change remains uncommitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant