You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Today reviewed state is preserved by path across R reload. That is useful, but it can also keep a file marked reviewed after new commits changed the same path.
Would it make sense to store a per-file fingerprint when the user marks a file reviewed, and on reload keep the reviewed mark only if the fingerprint still matches? Similar to GitHub PR “Viewed” behavior.
Fingerprint probably should be based on the rendered diff state, not only the working-tree file hash, so rebases/new commits that do not change the effective file diff keep the reviewed mark, while real changes clear it.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
UPDATE: merged as #256
Today reviewed state is preserved by path across
Rreload. That is useful, but it can also keep a file marked reviewed after new commits changed the same path.Would it make sense to store a per-file fingerprint when the user marks a file reviewed, and on reload keep the reviewed mark only if the fingerprint still matches? Similar to GitHub PR “Viewed” behavior.
Fingerprint probably should be based on the rendered diff state, not only the working-tree file hash, so rebases/new commits that do not change the effective file diff keep the reviewed mark, while real changes clear it.
All reactions