Idea: Consider moving comment history out of ~/.config

[fgrehm]

Hey there! First of all: great tool, I love using it! At some point I thought of building something similar but was glad to find your "waaaay more polished version" of my ideas a while ago 😃

Got a small nit about review history: I just found out that those are saved in ~/.config/revdiff/history/<repo-name>/<timestamp>.md but feels a bit weird for those to be in a configuration folder.

Would you be open to using another XDG directory? If so, I'd vote for XDG_DATA_HOME (.local/share) or XDG_STATE_HOME (.local/state).

[umputun]

yeah, I kind of agree the history bit feels a little out of place, which is exactly why REVDIFF_HISTORY_DIR exists as an override.

the reason I picked ~/.config/revdiff/history in the first place is simple - I didn't want revdiff-related files scattered across multiple places. config, keybindings, themes, history all under the same roof keeps things easy to find and easy to back up.

history value is also fairly short-term. in theory it could live in /tmp since all it serves is a fallback/recovery mechanism after an accidental quit or crash. practically I don't see much of a real problem keeping it in ~/.config/revdiff/history by default. if someone wants to source-control that directory they can gitignore history/ if desirable.

so for now I'd rather leave the default as is and keep REVDIFF_HISTORY_DIR for anyone who wants it elsewhere.

[fgrehm]

Thanks for the reply :) I also have mixed feelings about the "XDG scattered philosophy" and I understand where you're coming from. I was about to ask if you'd be open to a config for it instead of env var but turns out you got that handled already!

Gonna close the discussion and leave a note about what I did here:

# ~/.config/revdiff/config
[Application Options]
; directory for review history auto-saves
history-dir = /tmp/revdiff/history

Cheers!