Replies: 4 comments 2 replies
|
the "why" here is unclear. "other diff tools do it this way" isn't really a reason, and honestly github isn't a great benchmark for reviews, it's hard to make sense of isolated hunks there with only minimal surrounding context. revdiff isn't a generic diff tool, it's a review tool that happens to work with diffs. the full-file-with-context default is intentional, and the whole design is built around one goal: helping decide whether the changes under review make sense in the context of the full source code. annotating any line, showing code in context, syntax highlighting across the whole file, all of it serves that goal. flipping the default isn't something I'd consider, and I don't see a strong case for adding it as a toggle either. isolated-diff review isn't really what revdiff is for. closing. |
|
i will move it to discussions |
|
the concrete case is fair, multi-thousand-line translations file with a one-line change, having to hit that said, "other diff tools do it this way" still doesn't move me. revdiff has its own goal, and my view is the right way to handle this is one simpler middle ground I can see for your case: a toggle to switch the underlying diff context from full-file ( |
|
Thanks a lot @umputun that's really a great option and a nice middle ground solution. |


Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Problem

So currently the default is the full file view (which make sense in some cases) but the default for most diff-tools is the cut off version of the file. Only the changed lines are shown e.g. Github:
Solution
Make it the default to only view changes lines with an option to show the full file.
All reactions