Skip to content

Fix/22 3-button navigation buttons overlaying app#23

Open
lebouquetin wants to merge 2 commits into
mainfrom
fix/22__3-button-navigation_buttons_overlaying_app
Open

Fix/22 3-button navigation buttons overlaying app#23
lebouquetin wants to merge 2 commits into
mainfrom
fix/22__3-button-navigation_buttons_overlaying_app

Conversation

@lebouquetin

@lebouquetin lebouquetin commented May 5, 2026

Copy link
Copy Markdown
Contributor

Fixes #22

Checkpoints

For developers

  • If relevant, manual tests have been done to ensure the stability of the whole application and that the involved feature works.
  • The original issue is up to date w.r.t the latest discussions and contains a short summary of the implemented solution.
  • Make sure that relevant people for these changes are notified.
  • Original authors of the feature should be part of the reviewers, especially if you encountered merge conflicts.

For code reviewers

  • The code is clear enough and follow code rules.
  • If there are FIXMEs in the code, related issues are mentioned in the FIXME.
  • If there are TODOs, NOTEs or HACKs in code, the date and the developer initials are present.

For testers

  • Manual, quality tests have been done.

@piRGoif piRGoif left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only add a link to the documentation (seems it is https://docs.expo.dev/versions/latest/sdk/safe-area-context/ ?), maybe in the issue itself ?

@lebouquetin

Copy link
Copy Markdown
Contributor Author

I would only add a link to the documentation (seems it is https://docs.expo.dev/versions/latest/sdk/safe-area-context/ ?), maybe in the issue itself ?

Adding this link in the issue is a good idea, I think. Go ahead 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug: 3 buttons navigation overlaying add server button at bottom of the application

2 participants