Skip to content

list: sold listings are reported as "active" #1

Description

@untitaker

Description

willhaben list shows Status: active for listings that have already been sold.

Steps to reproduce

  1. Mark a listing as sold on willhaben
  2. Run willhaben list (or willhaben list --json)
  3. The sold listing is still reported as active

Actual behavior

On my account, 27 of 28 listings that are sold are reported as active:

$ willhaben list --json | jq -r '.listings[] | "\(.status)\t\(.title)"'
active    <sold item A>
active    <sold item B>
inactive  <sold item C>
active    <sold item D>
...

Interestingly one of them does come back as inactive, so the behaviour is not
uniform across listings.

Expected behavior

Sold listings should be distinguishable from active ones.

Note that Listing["status"] currently has no sold variant — src/api/listings.ts
maps sold onto "inactive", so even when the status is picked up correctly a sold
listing cannot be told apart from one that is merely inactive. A dedicated sold
status would be useful.

Environment

  • willhaben-cli 1.0.0 (release v0.0.1, willhaben-darwin-arm64)
  • macOS arm64

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions