Skip to content

PERF-14 · Remove debug logging from the param-evaluation hot path #77

Description

@kiwifellows

Part of #63.

Problem

RulesEngine::evaluateParams() and evaluatePhpExpression() emit Log::debug on every parameter of every action (app/app/Services/RulesEngine/RulesEngine.php:394, :488). Harmless at info, expensive at debug — which is exactly what DEBUG.md tells people to turn on when investigating a scan.

Change

Remove the per-parameter debug logging from the hot path, or gate it behind a check that does not build the context array when the level is not enabled.

Priority: P2

Metadata

Metadata

Assignees

No one assigned

    Labels

    performanceScan speed, throughput, resource useroadmap:laterReal, but waiting on a triggersize/XSUnder a day

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions