storybook build not exiting

[Profesor08]

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch storybook@10.3.4 for the project I'm working on.

When storybook build runs, it not exiting after build is done

Here is the diff that solved my problem:

diff --git a/node_modules/storybook/dist/bin/core.js b/node_modules/storybook/dist/bin/core.js
index 2e10e85..c38bb6b 100644
--- a/node_modules/storybook/dist/bin/core.js
+++ b/node_modules/storybook/dist/bin/core.js
@@ -2828,6 +2828,7 @@ command("build").option("-o, --output-dir <dir-name>", "Directory where to store
   }).catch(() => {
     logger2.outro("Storybook exited with an error"), process.exit(1);
   }), logger2.outro("Storybook build completed successfully");
+  process.exit(0);
 });
 command("index").option("-o, --output-file <file-name>", "JSON file to output index").option("-c, --config-dir <dir-name>", "Directory where to load Storybook configurations from").option("--quiet", "Suppress verbose build output").action(async (options) => {
   let { env } = process;

This issue body was partially generated by patch-package.

{
  "scripts": {
    "build:storybook": "storybook build --output-dir .storybook-static --disable-telemetry",
    "storybook": "storybook dev -p 6006 --no-open --no-version-updates",
  },
  "devDependencies": {
    "@storybook/addon-docs": "^10.3.4",
    "@storybook/nextjs-vite": "^10.3.4",
    "storybook": "^10.3.4",
  },
}

import type { StorybookConfig } from "@storybook/nextjs-vite";

const config: StorybookConfig = {
  stories: ["../src/ui/**/*.mdx", "../src/**/*.stories.@(js|jsx|mjs|ts|tsx)"],
  addons: ["@storybook/addon-docs"],
  framework: "@storybook/nextjs-vite",
  staticDirs: [],
  core: {
    disableTelemetry: true, // 👈 Disables telemetry
    disableWhatsNewNotifications: true,
  },
  docs: {
    defaultName: "Documentation",
  },
};

export default config;

[Maximiliano-Zeballos]

Hi @Profesor08, thanks for the detailed report and the patch.

I tried to reproduce this with the same setup (storybook 10.3.4, @storybook/nextjs-vite, addon-docs, telemetry disabled) but the build process exits normally for me (~2s). Tested on Windows 11 / Node 22.

Looking at the source (code/core/src/bin/core.ts), the error path does call process.exit(1) but the happy path doesn't have process.exit(0), so if any async handle stays open (logger streams, HTTP keep-alive from telemetry, DNS lookups), Node won't exit. This has been reported several times before (#16766, #24320, #22985).

Could you share:

• Your OS and Node.js version (node -v)
• Whether it hangs indefinitely or eventually exits
• Output of npx why-is-node-running if possible (or add --require why-is-node-running/include to see active handles when it hangs)

That would help confirm which handles are keeping the process alive in your environment.

[Profesor08]

OS: Windows 11
node: v25.6.1

It happens every time

It was tricky to run why-is-node-running, and I don't know what to expect from it

$ node --require why-is-node-running/include node_modules/storybook/dist/bin/dispatcher.js build --output-dir .storybook-static --disable-telemetry --loglevel error
kill -SIGUSR1 6876 for logging
kill -SIGUSR1 6876 for logging

kill -SIGUSR1 6876 in git bash not finding process, so I attached debugger node -e "process._debugProcess(25364)" and no console logs found

process.listeners('SIGUSR1')[0]() prints next logs

console-1775155182858.log

[Maximiliano-Zeballos]

Thanks for running that! The log shows 132 active handles after the build finishes. The vast majority (~126) are FSEVENTWRAP, which are file system watchers from Vite/chokidar that never get closed once the build is done. The rest are 3 TTYWRAP, 1 DNSCHANNEL, and 2 CustomGC.

There's no clean way for the build command to tear all of those down, so your process.exit(0) patch makes sense to me. The error path already does process.exit(1), so it'd be consistent.

Happy to open a PR for this if the team is on board. @valentinpalkovic what do you think?

[valentinpalkovic]

@Maximiliano-Zeballos Feel free to open a PR!