What goes wrong
The "We Recommend" dialog in the library shows a broken image for three of its twelve entries, on every platform and every install. The backend logs a 404 each time the dialog is opened:
GET /img/friends/analog4lyfe.jpg HTTP/1.1" 404 Not Found
GET /img/friends/empress-effects.png HTTP/1.1" 404 Not Found
GET /img/friends/thomann.jpg HTTP/1.1" 404 Not Found
Why
FRIENDS in static/js/catalog.js lists eight entries with a logo path. Only five of those files exist in static/img/friends/. The other three were never committed.
The comment above the array says the logos are bundled "so they render offline", so the intent is clear: these are meant to be local files, not remote fetches. Nothing warns when a listed logo has no file behind it, which is why three of them sat broken.
Who it affects
Everyone. It is not platform specific and not a packaging fault. The files are absent from the repository itself, so every build has the same gap. The affected entries fall back to nothing rather than to the initial-letter badge that logo-less entries get, so the card looks broken rather than plain.
Reproduction
- Open StemDeck.
- Open the We Recommend dialog at the bottom of the library.
- Analog4Lyfe, Empress Effects and Thomann show a broken image.
- The backend log has a 404 for each.
Constraints for a fix
Two entries are Instagram accounts, where the public profile page exposes a 100x100 avatar and nothing larger. That matches the size of the five avatars already bundled, so it is consistent, but it is the ceiling without asking the account owner for a larger file. Empress Effects publishes a proper logo on its own site.
A fix should also make the mismatch visible rather than silent. A listed logo with no file behind it is a broken card, and nothing in the tests or the build catches it today.
What goes wrong
The "We Recommend" dialog in the library shows a broken image for three of its twelve entries, on every platform and every install. The backend logs a 404 each time the dialog is opened:
Why
FRIENDSinstatic/js/catalog.jslists eight entries with alogopath. Only five of those files exist instatic/img/friends/. The other three were never committed.The comment above the array says the logos are bundled "so they render offline", so the intent is clear: these are meant to be local files, not remote fetches. Nothing warns when a listed logo has no file behind it, which is why three of them sat broken.
Who it affects
Everyone. It is not platform specific and not a packaging fault. The files are absent from the repository itself, so every build has the same gap. The affected entries fall back to nothing rather than to the initial-letter badge that logo-less entries get, so the card looks broken rather than plain.
Reproduction
Constraints for a fix
Two entries are Instagram accounts, where the public profile page exposes a 100x100 avatar and nothing larger. That matches the size of the five avatars already bundled, so it is consistent, but it is the ceiling without asking the account owner for a larger file. Empress Effects publishes a proper logo on its own site.
A fix should also make the mismatch visible rather than silent. A listed
logowith no file behind it is a broken card, and nothing in the tests or the build catches it today.