Offering a Spanish translation — checking scope and preferences first

[diegoarusso]

Offer

I'd like to contribute a Spanish translation, if you want one. Asking first
rather than opening a PR, since CONTRIBUTING asks for that on anything large
and 461 keys qualifies.

LANGUAGES currently covers en, pl, ja, zh-Hans, de, fr, pt, pt-PT and id.
Spanish looks like the largest gap left by speaker count.

Questions before I start

1. Do you want it at all? You may already have someone lined up, or reasons
for the current set that I can't see from outside.

2. Which code — and which flag? A neutral es seems right for a first pass,
but every LANGUAGES entry carries a flag, and there isn't an uncontroversial
one for neutral Spanish. 🇪🇸 reads as Spain specifically, which cuts against a
neutral table. Options I can see: neutral es with whichever flag you prefer,
or es + an es-419 variant later using the FALLBACK mechanism the way
pt-PT does. Your call — you've clearly thought about the variant question
already, given the comment above FALLBACK.

3. How do you feel about AI-assisted drafting? I'd draft with an AI model
and review every string myself as a native speaker. I'd rather say that up
front than have you find out later. Some projects don't accept machine-drafted
translation at any level of review, and if that's your position here, that's a
fine answer and I'll drop it. I'm also happy to do it unassisted if you'd
prefer, it just takes longer.

For what it's worth on the review side: I'm a native speaker and a working
musician, so the part I'd actually be useful for is the domain vocabulary —
stems, pitch, tempo, click track, mixdown, solo/mute. Those are where a
translation usually goes wrong, and where a literal rendering is worse than
leaving the English in place.

What I'd hold myself to

I read #415 before opening this, so I know the bar isn't a string dump. Full
key parity against the 461 English keys, plural rules, and a visual pass rather
than assuming it fits.

Length is the specific thing I'd expect trouble from: Spanish tends to run
noticeably longer than English, which is the same pressure that made you widen
the language dropdown and device select in #415. I'd check for truncation
across the settings tabs and the mixer rather than hand you something that
looks fine only in the views I happened to open.

I'd also treat it as ongoing rather than one-and-done. The current tables sit
between 439 and 465 keys against English's 461, so I understand languages drift
as features land, and I'd plan to keep it current rather than add a tenth table
for someone else to maintain.

Not urgent

Happy to wait on this, or to drop it entirely if it doesn't fit your plans.

[thcp]

Hola @diegoarusso , estaré encantado de recibir tu contribución :D
ES me parece bien, aunque estoy abierto a tu propuesta. Tampoco tengo ningún inconveniente con que utilices IA para preparar un primer borrador, ya que yo mismo la utilizo como apoyo en buena parte de mi trabajo, especialmente para el seguimiento de proyectos y la revisión de código.
¡Adelante! ❤️

[diegoarusso]

The translation is done, but I can't open the PR:

An owner of this repository has limited the ability to open a pull request to
users that are collaborators on this repository.

The compare view itself is happy — "Able to merge, these branches can be
automatically merged" — so this is just the repo setting, not the branch.
Flagging it because CONTRIBUTING invites outside PRs, so I suspect it isn't
deliberate. It would block anyone who isn't already a collaborator.

I'd rather stay an outside contributor than take write access on your repo, so
two options that don't involve that: relax the setting so fork PRs work in
general, or just pull the branch directly. It's

https://github.com/diegoarusso/stemdeck.git  feat/spanish-translation

one commit, af0d92a, only static/js/i18n.js. It'll stay there, so pull it
whenever suits you — or not at all, no hard feelings either way.

Since you can't see a PR description, the short version:

Coverage. All 461 English keys. Only one/other plurals, since Spanish
has no few/many and plural() only routes those for Polish — same as de.

Vocabulary. Neutral Spanish, no regional forms. Two English pairs collapse
into one Spanish word and were split deliberately: track/stems → "pista"/stems
(60 and 53 keys, they'd collide), and key/pitch → "tonalidad"/"tono". Mute,
Solo, Fader, Loop, Click and Stems stay in English because that's how they're
spoken in a studio, though full sentences still read naturally —
export.allMuted uses "silenciados", not "en mute". beat is "tiempo", not
"tempo": they're draggable objects on the grid, and BPM has its own keys.

GRID keeps its English label — the neutral Spanish word overflows the
beatgrid toolbar and the short alternative is regional.

Length. I measured growth per string rather than assuming, since this is
what made you widen controls in #415. Five were shortened first, mostly the
logs tabs: the group is already "Registros", so "Registro de…" in each tab was
redundant and wide.

Verified. node --check; the JS suite the way test:js runs it, 4/4; key
parity at runtime, 451/451 with nothing missing or extra; placeholder and
HTML-tag parity on every string; live language switch; and an overflow audit
(scrollWidth > clientWidth on every text-bearing element) across the main
view and all five settings tabs — zero overflows.

Not covered: anything needing a processed track, so the beatgrid toolbar, job
states and the export dialog are eyeball-only from string lengths.

Drafted with AI assistance and reviewed by me as a native speaker, as agreed
above. The vocabulary calls are mine.

[thcp]

Your Spanish is in. It is up as #469, pulled straight from your fork, so the commit is yours.

Thank you for this. You asked first, you waited on an answer, and then you handed over work that needed almost nothing from me. That combination is rare.

The vocabulary is the part I could not have got anywhere else. tiempo fuerte, compás, golpe de batería, and keeping tonalidad apart from tono where Spanish wants them to be one word. You said the domain was where you would actually be useful. You were right.

Everything you said you had checked, I checked too, and all of it held. Key parity, placeholders, plural families, the overflow audit across all five settings tabs. The neutral claim was the one I expected to find soft, and it turned out to be the most solid of the lot: archivo seventeen times and fichero never, the tú form throughout and usted nowhere. That is a register someone chose and then stayed inside.

I read the whole diff rather than your summary of it, since it came in from a fork. That is just what has to happen with any outside branch, and I would rather say so than have you wonder.

Two things I added on top, both mine.

Four keys. settings.autoDelete.* landed on main after you branched, so your table was complete against the English it left and short only against the English it arrived at. I wrote them to your conventions rather than my own: pista, eliminar, "no se puede deshacer" from your settings.resetData.desc, "salvo que" from your settings.cookies.desc. If any of it reads wrong to you, say so and I will take your wording over mine.

The other one you had no way of seeing from outside. _detectDefault had no branch for es, so the table would have shipped unreachable: in the picker, fully translated, and never once chosen by anyone whose browser said es-MX. Chasing that turned up French with the same gap, already shipped and quietly serving English to French speakers. That is #467 now. Both are fixed, with a test so the next language cannot slip through the same way.

On the PR restriction, you were right that it is not deliberate. It is flagged and being sorted. Thank you for routing around it rather than walking away, and for offering the branch instead of asking for write access. Both were the better instinct.

A data-loss bug and a language table in the same week, from someone under no obligation to do either. Let me know how the Spanish reads once it ships, and if you spot anything you want changed, it is your table.

[thcp]

@diegoarusso Merged. Spanish is on main now.

If you want to see it running before the next release, pull main and start it however you normally do, then pick Español in Settings. It is frontend only, so nothing needs rebuilding beyond having the new static/js/i18n.js on disk. Your browser reporting es-* will now pick it on its own too, which it would not have done before.

The parts I would most like your eye on are the four settings.autoDelete.* strings I wrote into your table, and anything that looks cramped rather than wrong. My overflow audit came back clean across all five settings tabs, but that is a script measuring boxes. You will notice things it cannot.

No rush, and no obligation. It is your table, so if something reads off to you, say so and it gets changed.