From ee5a4fe4641d790664932c8f53b37226871dcc93 Mon Sep 17 00:00:00 2001
From: Rassl <rasul.sahibjanli@gmail.com>
Date: Tue, 28 Jul 2026 11:46:17 +0700
Subject: [PATCH] fix: show human review as Sent once dispatched, not Sending
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

A human review runs for as long as a human takes, so a PENDING/RUNNING
StakworkRun rendered "Sending…" with a spinner for that entire duration —
implying the dispatch was still in progress when it had already completed.

The spinner is now scoped to the POST itself (sub-second). Once a run
exists, running and completed both read "Sent", which is the only fact the
operator needs. Polling is unchanged: onCompleted still refreshes the list
when the workflow's results land as new Reviews.

The sent state is now genuinely disabled rather than only click-guarded.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
---
 src/components/admin/review-row.tsx | 32 +++++++++++++++++------------
 src/lib/__tests__/reviews.test.tsx  | 13 +++++++-----
 2 files changed, 27 insertions(+), 18 deletions(-)

diff --git a/src/components/admin/review-row.tsx b/src/components/admin/review-row.tsx
index c9de0a2..3cfb34f 100644
--- a/src/components/admin/review-row.tsx
+++ b/src/components/admin/review-row.tsx
@@ -583,6 +583,14 @@ export function ReviewRow({
     }
   )
 
+  // A human review takes as long as it takes — showing its run as "Sending…"
+  // for that whole time reads as though the dispatch is still going. Once the
+  // run exists, the only fact the operator needs is that it was sent, so an
+  // in-flight run and a completed one look the same here. Polling continues
+  // regardless: onCompleted is what surfaces the workflow's results.
+  const humanReviewSent =
+    humanReviewStatus === "COMPLETED" || humanReviewInFlight
+
   // ── Merge-specific interactive state ────────────────────────────────────────
   const [checkedSources, setCheckedSources] = useState<Set<string>>(new Set())
   const [canonicalId, setCanonicalId] = useState<string>("")
@@ -778,38 +786,36 @@ export function ReviewRow({
                 <button
                   type="button"
                   data-testid="send-for-human-review-btn"
-                  disabled={humanReviewInFlight || humanReviewTriggering}
+                  disabled={humanReviewSent || humanReviewTriggering}
                   onClick={(e) => {
                     e.stopPropagation()
-                    if (humanReviewStatus === "COMPLETED") return
+                    if (humanReviewSent) return
                     triggerHumanReview(() => triggerMergeWorkflow(review.ref_id))
                   }}
                   title={
-                    humanReviewInFlight
-                      ? "Human review in progress…"
-                      : humanReviewStatus === "COMPLETED"
-                        ? "Human review completed"
-                        : humanReviewStatus === "FAILED"
-                          ? "Review failed — click to retry"
-                          : "Send for human review"
+                    humanReviewSent
+                      ? "Sent for human review"
+                      : humanReviewStatus === "FAILED"
+                        ? "Review failed — click to retry"
+                        : "Send for human review"
                   }
                   className={cn(
                     "inline-flex shrink-0 items-center gap-1 whitespace-nowrap rounded border px-2 py-0.5 text-[11px] font-medium transition-all",
-                    humanReviewInFlight || humanReviewTriggering
+                    humanReviewTriggering
                       ? "cursor-not-allowed border-sky-500/40 bg-sky-500/10 text-sky-300"
-                      : humanReviewStatus === "COMPLETED"
+                      : humanReviewSent
                         ? "cursor-default border-emerald-500/40 bg-emerald-500/10 text-emerald-300"
                         : humanReviewStatus === "FAILED"
                           ? "border-red-500/40 bg-red-500/5 text-red-400 hover:border-red-500/70 hover:bg-red-500/15"
                           : "border-sky-500/30 bg-sky-500/5 text-sky-400 hover:border-sky-500/60 hover:bg-sky-500/10"
                   )}
                 >
-                  {humanReviewInFlight || humanReviewTriggering ? (
+                  {humanReviewTriggering ? (
                     <>
                       <Loader2 className="h-3 w-3 animate-spin" />
                       Sending…
                     </>
-                  ) : humanReviewStatus === "COMPLETED" ? (
+                  ) : humanReviewSent ? (
                     <>
                       <CheckCircle2 className="h-3 w-3" />
                       Sent
diff --git a/src/lib/__tests__/reviews.test.tsx b/src/lib/__tests__/reviews.test.tsx
index f7b2b31..5c3eabf 100644
--- a/src/lib/__tests__/reviews.test.tsx
+++ b/src/lib/__tests__/reviews.test.tsx
@@ -1307,9 +1307,9 @@ describe("ReviewRow — Send for Human Review button", () => {
 
     await waitFor(() => {
       expect(btn.textContent).toMatch(/Sent/i)
-      // COMPLETED: not disabled by the HTML attribute, but click is a no-op
-      // (disabled only when humanReviewInFlight || humanReviewTriggering)
-      expect(btn).not.toHaveProperty("disabled", true)
+      // Once sent, the button is genuinely disabled rather than merely
+      // click-guarded — nothing is left to send.
+      expect(btn).toHaveProperty("disabled", true)
     })
   })
 
@@ -1347,7 +1347,7 @@ describe("ReviewRow — Send for Human Review button", () => {
     })
   })
 
-  it("hydrates to RUNNING and shows Sending… (button disabled while in-flight)", async () => {
+  it("hydrates to RUNNING and shows Sent (not Sending — the dispatch is done)", async () => {
     mockGetLatestStakworkRun.mockResolvedValueOnce({
       ref_id: "mock-run-789",
       job_type: "node_merge_review",
@@ -1362,8 +1362,11 @@ describe("ReviewRow — Send for Human Review button", () => {
     )
     const btn = await findByTestId("send-for-human-review-btn")
 
+    // A human review runs for as long as a human takes; "Sending…" would imply
+    // the dispatch is still in progress. Once a run exists it is simply sent.
     await waitFor(() => {
-      expect(btn.textContent).toMatch(/Sending/i)
+      expect(btn.textContent).toMatch(/Sent/i)
+      expect(btn.textContent).not.toMatch(/Sending/i)
       expect(btn).toHaveProperty("disabled", true)
     })
   })