From 87363dcc6dc2d996e9234115e607534a9a8b0b76 Mon Sep 17 00:00:00 2001 From: Mauro Ezequiel Moltrasio Date: Fri, 8 May 2026 11:54:19 +0200 Subject: [PATCH 1/4] feat(ci): validate checklist is updated This is a small CI check that verifies a few fields in the checklist section of the PR description is updated. If this is not too disruptive, we can probably make the check required in the near future. --- .github/workflows/pr-checklist.yml | 34 ++++++++++++++++++++++++++++++ 1 file changed, 34 insertions(+) create mode 100644 .github/workflows/pr-checklist.yml diff --git a/.github/workflows/pr-checklist.yml b/.github/workflows/pr-checklist.yml new file mode 100644 index 00000000..f722bced --- /dev/null +++ b/.github/workflows/pr-checklist.yml @@ -0,0 +1,34 @@ +name: "Enforce PR Checklist" + +on: + pull_request: + types: + - opened + - edited + - synchronize + - reopened + +jobs: + validate-checklist: + runs-on: ubuntu-24.04 + if: github.event.pull_request.draft == false + steps: + - name: Verify PR Checklist is Complete + if: github.actor != 'red-hat-konflux[bot]' + env: + PR_BODY: ${{ github.event.pull_request.body }} + run: | + if ! (echo "$PR_BODY" | grep "\- \[x\] Patch has a change log entry \*\*OR\*\* does not need one"); then + echo "Missing change log check" + exit 1 + fi + + if ! (echo "$PR_BODY" | grep "\- \[x\] Investigated and inspected CI test results"); then + echo "Missing CI test check" + exit 1 + fi + + - name: Skip check for MintMaker + if: github.actor == 'red-hat-konflux[bot]' + run: | + echo "MintMaker PRs are exempted from this check" From 1917edbf21c1e4de586c8f58d358201dc10435c3 Mon Sep 17 00:00:00 2001 From: Mauro Ezequiel Moltrasio Date: Fri, 8 May 2026 11:58:32 +0200 Subject: [PATCH 2/4] Remove draft check for testing --- .github/workflows/pr-checklist.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-checklist.yml b/.github/workflows/pr-checklist.yml index f722bced..a34db750 100644 --- a/.github/workflows/pr-checklist.yml +++ b/.github/workflows/pr-checklist.yml @@ -11,7 +11,7 @@ on: jobs: validate-checklist: runs-on: ubuntu-24.04 - if: github.event.pull_request.draft == false + #if: github.event.pull_request.draft == false steps: - name: Verify PR Checklist is Complete if: github.actor != 'red-hat-konflux[bot]' From 69c4e4c1800ae3d5a774a44224a97a839c4a54df Mon Sep 17 00:00:00 2001 From: Mauro Ezequiel Moltrasio Date: Fri, 8 May 2026 12:02:29 +0200 Subject: [PATCH 3/4] Add missing -q flag --- .github/workflows/pr-checklist.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr-checklist.yml b/.github/workflows/pr-checklist.yml index a34db750..519f9a82 100644 --- a/.github/workflows/pr-checklist.yml +++ b/.github/workflows/pr-checklist.yml @@ -18,12 +18,12 @@ jobs: env: PR_BODY: ${{ github.event.pull_request.body }} run: | - if ! (echo "$PR_BODY" | grep "\- \[x\] Patch has a change log entry \*\*OR\*\* does not need one"); then + if ! (echo "$PR_BODY" | grep -q "\- \[x\] Patch has a change log entry \*\*OR\*\* does not need one"); then echo "Missing change log check" exit 1 fi - if ! (echo "$PR_BODY" | grep "\- \[x\] Investigated and inspected CI test results"); then + if ! (echo "$PR_BODY" | grep -q "\- \[x\] Investigated and inspected CI test results"); then echo "Missing CI test check" exit 1 fi From 69e6152981b202998c01bd79182c88bd4fb6b47e Mon Sep 17 00:00:00 2001 From: Mauro Ezequiel Moltrasio Date: Fri, 8 May 2026 12:05:08 +0200 Subject: [PATCH 4/4] Revert "Remove draft check for testing" This reverts commit 1917edbf21c1e4de586c8f58d358201dc10435c3. --- .github/workflows/pr-checklist.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr-checklist.yml b/.github/workflows/pr-checklist.yml index 519f9a82..45bbd153 100644 --- a/.github/workflows/pr-checklist.yml +++ b/.github/workflows/pr-checklist.yml @@ -11,7 +11,7 @@ on: jobs: validate-checklist: runs-on: ubuntu-24.04 - #if: github.event.pull_request.draft == false + if: github.event.pull_request.draft == false steps: - name: Verify PR Checklist is Complete if: github.actor != 'red-hat-konflux[bot]'