params in request options will not stringify if already a string

Author: ultravioletasdf

.prettierrc.yaml

@@ -0,0 +1,6 @@
+semi: false
+singleQuote: true
+useTabs: true
+bracketSpacing: true
+arrowParens: always
+trailingComma: none

CHANGELOG.md

@@ -13,3 +13,7 @@ Another `README.md` update
 # 1.0.3
 
 Fixed type exports in `package.json`
+
+# 1.0.4
+
+params in request options will not stringify if already a string

package.json

@@ -1,7 +1,8 @@
 {
 	"name": "@splitscript.js/https",
-	"version": "1.0.3",
+	"version": "1.0.4",
 	"description": "Send HTTPS/HTTP requests",
+	"types": "./dist/types/index.d.ts",
 	"exports": {
 		".": {
 			"import": "./dist/esm/index.js",

src/index.ts

@@ -1,15 +1,15 @@
-import * as https from 'node:https';
-import * as http from 'node:http';
-import { isHttps, parseData, toQuery } from './utils.js';
+import * as https from 'node:https'
+import * as http from 'node:http'
+import { isHttps, parseData, toQuery } from './utils.js'
 type Request = http.RequestOptions & {
-	body?: any;
-	params?: object;
-};
+	body?: any
+	params?: object
+}
 
 type requestRes = {
-	res: http.IncomingMessage;
-	data: string | object;
-};
+	res: http.IncomingMessage
+	data: string | object
+}
 /**
  * Send a `http(s)` request
  *
@@ -20,66 +20,66 @@ export function request(
 	options: Request = { method: 'GET' }
 ): Promise<requestRes> {
 	if (!url.startsWith('https://') && !url.startsWith('http://')) {
-		url = (options.port === 80 ? 'http://' : 'https://') + url;
+		url = (options.port === 80 ? 'http://' : 'https://') + url
 	}
-	const client = isHttps(url, options) ? https : http;
+	const client = isHttps(url, options) ? https : http
 	if (options.params) {
-		url += toQuery(options.params);
+		url += toQuery(options.params)
 	}
 	return new Promise((resolve, reject) => {
 		const req = client.request(url, options, (res) => {
-			let data = '';
+			let data = ''
 
-			res.setEncoding('utf-8');
+			res.setEncoding('utf-8')
 			res.on('data', (chunk: string) => {
-				data += chunk;
-			});
+				data += chunk
+			})
 
 			res.on('end', () => {
-				resolve({ res, data: parseData(res, data) });
-			});
-		});
-		req.on('error', reject);
+				resolve({ res, data: parseData(res, data) })
+			})
+		})
+		req.on('error', reject)
 		if (options.body) {
-			req.write(Buffer.from(JSON.stringify(options.body)));
+			req.write(Buffer.from(JSON.stringify(options.body)))
 		}
-		req.end();
-	});
+		req.end()
+	})
 }
 /** Sends a `GET` request */
 export function get(
 	url: string,
 	options: Request = { method: 'GET' }
 ): Promise<requestRes> {
-	return request(url, { method: 'GET', ...options });
+	return request(url, { method: 'GET', ...options })
 }
 /** Sends a `POST` request */
 export function post(
 	url: string,
 	options: Request = { method: 'POST' }
 ): Promise<requestRes> {
-	return request(url, { method: 'POST', ...options });
+	return request(url, { method: 'POST', ...options })
 }
 /** Sends a `PUT` request */
 export function put(
 	url: string,
 	options: Request = { method: 'PUT' }
 ): Promise<requestRes> {
-	return request(url, { method: 'PUT', ...options });
+	return request(url, { method: 'PUT', ...options })
 }
 /** Sends a `PATCH` request */
 export function patch(
 	url: string,
 	options: Request = { method: 'PATCH' }
 ): Promise<requestRes> {
-	return request(url, { method: 'PATCH', ...options });
+	return request(url, { method: 'PATCH', ...options })
 }
 /** Sends a `DELETE` request */
 function _delete(
 	url: string,
 	options: Request = { method: 'DELETE' }
 ): Promise<requestRes> {
-	return request(url, { method: 'DELETE', ...options });
+	return request(url, { method: 'DELETE', ...options })
 }
-export { _delete as delete };
-export default { request, get, post, put, patch, delete: _delete };
+export { _delete as delete }
+export default { request, get, post, put, patch, delete: _delete }

src/utils.ts

@@ -1,20 +1,20 @@
-import { RequestOptions } from 'https';
-import { IncomingMessage } from 'http';
+import { RequestOptions } from 'https'
+import { IncomingMessage } from 'http'
 export function isHttps(url: string, options: RequestOptions = {}): boolean {
-	return url.startsWith('https://') || options.port === 443;
+	return url.startsWith('https://') || options.port === 443
 }
 export function parseData(res: IncomingMessage, data: any): string | object {
-	const type = res.headers['content-type']?.split(';')[0].trim();
+	const type = res.headers['content-type']?.split(';')[0].trim()
 	if (type === 'application/json') {
-		return JSON.parse(data);
-	} else return data;
+		return JSON.parse(data)
+	} else return data
 }
 export function toQuery(obj: object) {
 	const queryString = Object.entries(obj)
 		.map(([key, val]) => {
-			let stringified = JSON.stringify(val);
-			return `${key}=${encodeURIComponent(stringified)}`;
+			const stringified = typeof val === 'string' ? val : JSON.stringify(val)
+			return `${key}=${encodeURIComponent(stringified)}`
 		})
-		.join('&');
-	return '?' + queryString;
+		.join('&')
+	return '?' + queryString
 }