From 9bd23c52a3f9a0a3f76699505cc9b938116ce7bd Mon Sep 17 00:00:00 2001 From: blik616287 Date: Mon, 15 Jun 2026 00:24:29 -0500 Subject: [PATCH] fix: validator timeout and Node.js 24 action deprecations - Replace `crane pull` with `crane manifest` in validate_content(): pulling full image tarballs caused the validator to hang for 6 hours on large or slow-to-pull images, hitting the GitHub Actions job timeout. crane manifest hits only the registry manifest endpoint, giving the same existence guarantee with no layer download. - Bump actions/checkout v3.6.0 -> v4.2.2 and tj-actions/changed-files v46.0.1 -> v47.0.6 in pack-validation.yml. GitHub forces Node.js 24 on all runners from 2026-06-16; the pinned v3/v46 versions run on Node.js 20 and will break the workflow starting tomorrow. --- .github/workflows/pack-validation.yml | 4 ++-- validator/validate-packs.sh | 9 ++++----- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/pack-validation.yml b/.github/workflows/pack-validation.yml index 1be8fac4..465d945b 100644 --- a/.github/workflows/pack-validation.yml +++ b/.github/workflows/pack-validation.yml @@ -26,11 +26,11 @@ jobs: sudo tar -zxvf go-containerregistry.tar.gz -C /usr/local/bin/ crane # Checkout code - name: Checkout branch - uses: actions/checkout@f43a0e5ff2bd294095638e18286ca9a3d1956744 # v3.6.0 + uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 - name: Get changed files id: changed-files - uses: tj-actions/changed-files@2f7c5bfce28377bc069a65ba478de0a74aa0ca32 # v46.0.1 + uses: tj-actions/changed-files@9426d40962ed5378910ee2e21d5f8c6fcbf2dd96 # v47.0.6 # Run Validations - name: Check Packs diff --git a/validator/validate-packs.sh b/validator/validate-packs.sh index 922c7e38..b325da6c 100755 --- a/validator/validate-packs.sh +++ b/validator/validate-packs.sh @@ -195,14 +195,13 @@ validate_content(){ if [ "$img" != "" ]; then log_info "Valid entry $img found for image in $values_yaml_file" - crane pull $img image.tar + crane manifest $img > /dev/null 2>&1 if [ $? -eq 0 ]; then - log_info "Image pull succeeded for $img" - rm -f image.tar + log_info "Image manifest resolved for $img" else - log_error "Image pull failed. $img may not be a valid image" + log_error "Image manifest failed. $img may not be a valid image" fail=1 - fi + fi else log_error "Invalid entry $img found for images. images should have a -image entry in $values_yaml_file" fail =1