fix: ConfineIcuVersions is now respected by library discovery (#136)#222
Merged
Conversation
`CheckDirectoryForIcuBinaries` previously sorted candidates descending and unconditionally took the first entry, ignoring `MinIcuVersion` and `MaxIcuVersion`. It now iterates the sorted candidates and selects the first whose parsed version falls within [MinIcuVersion, MaxIcuVersion]. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…inaries Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Eliminates duplicated platform-dispatch logic in CheckDirectoryForIcuBinaries and fixes the sort to use numeric descending order, consistent with NativeMethodsHelper.TryGetIcuVersionNumber. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ermshiperete
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CheckDirectoryForIcuBinariesnow filters ICU library candidates to the range set byWrapper.ConfineIcuVersionsbefore selecting the highest version.NativeMethodsHelper.GetIcuVersionInfoForNetCoreOrWindows.Test plan
Wrapper.ConfineIcuVersions(54, 54)and verify the correct version is loadedCloses #136
🤖 Generated with Claude Code
Devin review: https://app.devin.ai/review/sillsdev/icu-dotnet/pull/222