Skip to content

scripts/verify-version.sh doesn't check MIDGE_VERSION_DATE #9

Description

@sidick

Flagged in the pre-release review, deliberately deferred (not a v0.1 blocker).

CLAUDE.md says a release PR must bump both MIDGE_VERSION and MIDGE_VERSION_DATE in src/version.h. scripts/verify-version.sh only checks the tag against MIDGE_VERSION and midge.readme's Version: field — it never checks MIDGE_VERSION_DATE.

Failure scenario: a release PR bumps the version but forgets the date; verify-version.sh passes, make dist's $VER grep also passes (it only matches the version number), and the release ships binaries whose $VER string carries the previous release's date.

Fix: add a check that MIDGE_VERSION_DATE actually changed since the last tag (or at minimum matches today's date format / isn't stale), alongside the existing version/readme checks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtech-debtDeliberately deferred fix or design tradeoff from a past review

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions