From 52cdb2c4b5806657e7fb1839b5d77561b4a06451 Mon Sep 17 00:00:00 2001 From: davidwei Date: Tue, 16 Jun 2026 20:35:59 +1200 Subject: [PATCH 1/2] docs: update CI_WORKFLOW.md Flutter version from 3.32.x to 3.38.x ci.yml has been on flutter-version 3.38.x since d171282 but the doc was not updated alongside. Also adds a keep-in-sync reminder at the top of the Workflow Jobs section to prevent future drift. Closes #39 Co-Authored-By: Claude Sonnet 4.6 --- CI_WORKFLOW.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/CI_WORKFLOW.md b/CI_WORKFLOW.md index 29a52045..339d5bb7 100644 --- a/CI_WORKFLOW.md +++ b/CI_WORKFLOW.md @@ -11,6 +11,8 @@ The CI workflow runs automatically on: - **Pull requests** to `main`, `master`, or `develop` branches - **Manual dispatch** (can be triggered manually from GitHub Actions tab) +> **Keep in sync**: this document mirrors `.github/workflows/ci.yml` and `android_release.yml`. Any `flutter-version` or `java-version` bump in the workflow must update this doc in the same commit. + ## Workflow Jobs ### 1. Test Job (`test`) @@ -19,7 +21,7 @@ This is the primary job that runs all Flutter unit tests and performs code quali **Steps:** - ✅ Checkout repository - ✅ Setup Java 17 (Oracle distribution) -- ✅ Setup Flutter 3.32.x (stable channel) +- ✅ Setup Flutter 3.38.x (stable channel) - ✅ Cache Flutter dependencies for faster builds - ✅ Create environment file (`.env`) with test configuration - ✅ Install Flutter dependencies From 26a9a90e37e48535c2b846cf3d031e75a60c88eb Mon Sep 17 00:00:00 2001 From: davidwei Date: Tue, 16 Jun 2026 20:44:23 +1200 Subject: [PATCH 2/2] docs: correct non-blocking status of analyze/format steps Review found that flutter analyze and dart format both run with continue-on-error: true in ci.yml, but CI_WORKFLOW.md presented them as blocking gates. Updated the steps list and the failure-handling section to accurately reflect that they report findings without failing the job. Co-Authored-By: Claude Sonnet 4.6 --- CI_WORKFLOW.md | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/CI_WORKFLOW.md b/CI_WORKFLOW.md index 339d5bb7..d432c82a 100644 --- a/CI_WORKFLOW.md +++ b/CI_WORKFLOW.md @@ -26,8 +26,8 @@ This is the primary job that runs all Flutter unit tests and performs code quali - ✅ Create environment file (`.env`) with test configuration - ✅ Install Flutter dependencies - ✅ Verify Flutter installation -- ✅ Analyze code with `flutter analyze --fatal-infos --fatal-warnings` -- ✅ Check code formatting with `dart format --set-exit-if-changed` +- ✅ Analyze code with `flutter analyze --fatal-infos --fatal-warnings` *(non-blocking: `continue-on-error: true`)* +- ✅ Check code formatting with `dart format --set-exit-if-changed` *(non-blocking: `continue-on-error: true`)* - ✅ Run tests with coverage using `flutter test --coverage --reporter expanded` - ✅ Upload test results and coverage reports as artifacts @@ -102,9 +102,10 @@ The workflow generates comprehensive test coverage reports: - ✅ Build and integration tests are skipped to save resources - ✅ Summary job still runs to provide consolidated status -### When Code Quality Checks Fail -- ✅ **Analysis failures**: Detailed warnings/errors shown in logs -- ✅ **Formatting failures**: Shows which files need formatting +### When Code Quality Checks Run With Issues +Note: `flutter analyze` and `dart format` run with `continue-on-error: true` — they report findings but do **not** fail the CI job. +- ✅ **Analysis warnings**: Shown in logs and the GitHub step summary +- ✅ **Formatting issues**: Listed in logs; run `dart format --page-width=120 .` locally to fix - ✅ **Build failures**: Full build logs available for debugging ## Local Testing