Allow review routes run on issues

[lolipopshock]

@sepo-agent /answer check #396 and then distill useful context

[sepo-agent-app]

I have enough context. I’m going to answer this as a distillation, with one caveat up front: the old issue has a claimed implementation comment, but the current code path still needs the changes.I checked #396 and current main.

Key context to keep:

• Allow review routes run on issues #396 already identified the right shape: support /review on issues as a focused default-branch review, while preserving existing PR diff review behavior.
• Important user requirement from Allow review routes run on issues #396: the triggering inline message must be passed through as request_text so the issue review has a clear goal/scope.
• Caveat: Allow review routes run on issues #396 has a Sepo comment saying this was implemented, but current main still looks PR-only, so treat Allow review routes run on issues #396 as design context, not landed code.

Current PR-only gates:

• Dispatch prompt says review is only valid for PRs: https://github.com/self-evolving/repo/blob/main/.github/prompts/agent-dispatch.md#L10-L15
• applyDispatchPolicy rejects issue review: https://github.com/self-evolving/repo/blob/main/.agent/src/triage.ts#L495-L503
• Router only dispatches review when target_kind == 'pull_request': https://github.com/self-evolving/repo/blob/main/.github/workflows/agent-router.yml#L1134-L1145
• agent-review.yml still requires pr_number and hardcodes target_kind: pull_request: https://github.com/self-evolving/repo/blob/main/.github/workflows/agent-review.yml#L3-L42 and https://github.com/self-evolving/repo/blob/main/.github/workflows/agent-review.yml#L220-L227
• Review prompt is still gh pr diff centered: https://github.com/self-evolving/repo/blob/main/.github/prompts/review.md#L3-L12

Recommended implementation distilled from #396:

1. Allow review for issue and pull_request in triage/policy; keep discussions unsupported.
2. Update agent-router.yml to dispatch review for issues too, passing target_kind, target_number, request_text, and source comment metadata.
3. Refactor agent-review.yml to be target-aware:
   • PR mode: keep current PR diff/head/inline/synthesis behavior.
   • Issue mode: review default branch, use the issue body/comments plus request_text as scope, skip PR-only head capture, PR inline comments, and PR-only rubric review behavior unless separately generalized.
4. Split or branch review prompts:
   • PR review uses gh pr view / gh pr diff.
   • Issue review uses gh issue view, repo inspection, and explicitly refuses broad whole-repo audit when scope is missing.
5. Post issue-mode synthesis back to the issue, not as a PR review/comment.
6. Add tests for explicit /review on issue, agent/review label on issue, unchanged PR review routing, and issue-mode no PR-only operations.

The most important acceptance criterion: issue /review should never silently become “review all of main.” It should require or infer a focused goal from the issue/comment text.

---

Sepo activity

Sepo finished — answer · 2m26s · 37 steps

Last message

I have enough context. I’m going to answer this as a distillation, with one caveat up front: the old issue has a claimed implementation comment, but the current code path still needs the changes.I checked #396 and current main. Key conte…

Activity

• 🔧 Used tool git branch -a --contains $(git rev-parse HEAD) | sed -n '1,120p' && git status --short (completed)
• 📖 Read Read triage.ts (completed)
• 📖 Read Read agent-dispatch.md (completed)
• 📖 Read Read agent-router.yml (completed)
• 📖 Read Read agent-review.yml (completed)
• 💬 Message "I have enough context. I’m going to answer this as a distillation, with one caveat up front: the old issue has a claimed implementation comment, but the current code path still needs the changes.I checked Allow review routes run on issues #396 and current main. Key conte…"

---

codex | gpt-5.5/xhigh | Macmini-runner-5

[lolipopshock]

@sepo-agent /implement

[sepo-agent-app]

Sepo implementation finished

• Branch: agent/implement-issue-442/codex-28504319921
• Pull request: Allow review route on issues #444

Implemented issue-scoped review routing: /review now passes policy on issues and PRs, the router forwards issue targets and trigger metadata into agent-review.yml, and the review workflow resolves target-aware inputs, skips PR-only head/rubrics/orchestration behavior for issue reviews, and posts synthesis back to issues. Updated review prompts, docs, and regression coverage; verified with build, focused tests, workflow/docs checks, and diff whitespace checks.

---

Sepo activity

Sepo finished — implement · 8m22s · 111 steps

Last message

{"summary":"Implemented issue-scoped review routing: /review now passes policy on issues and PRs, the router forwards issue targets and trigger metadata into agent-review.yml, and the review workflow resolves target-aware inputs, skips…

Activity

• 💬 Message "The relevant checks are clean. I’m doing a final working-tree/status review and a targeted source scan for hardcoded review target assumptions."
• 📖 Read Search Review requests are only supported|review.*only valid for 'pull_request'|needs\.portal\.outputs\.route == \'revi… (completed)
• 🔧 Used tool git status --short (completed)
• 🔧 Used tool git diff --stat (completed)
• 🔧 Used tool git diff --name-only (completed)
• 💬 Message "{"summary":"Implemented issue-scoped review routing: /review now passes policy on issues and PRs, the router forwards issue targets and trigger metadata into agent-review.yml, and the review workflow resolves target-aware inputs, skips…"

---

codex | gpt-5.5 | xhigh | Macmini-runner-4

[github-actions]

Closing because this agent issue has had no activity for 30 days.