Rename the `t` dimension to `tof`? (or not?)

[nvaytet]

The workflow that computes time-of-flight expects the data to have a tof coordinate and a tof dimension.
When loading data with scitiff, the tof coordinate is there, but the dimension is still t.

Can we rename the dim to tof to make downstream processing easier?

That said, tof is not necessarily a good name, because it isn't really tof that is recorded in the data, but toa (or event event_time_offset) instead of real tof.
In addition, once we have converted the data to real tof, if we save that to a tiff stack, the dimension should now be tof.

So maybe the generic t name, which would fit all of toa, tof and event_time_offset is better?
Maybe the renaming of coordinates/dimensions should be handled in the reduction software and scitiff should just use a generic t everywhere?

[damskii9992]

Just adding on to this issue what me and Neil just discussed regarding time-of-flight calibration:
We need to be able to save and load SciTiffs with either event_time_offset or tof as the time-dimension.
When running the reduction workflow, we will then produce 2 different SciTiffs, one before running the ToF conversion where the time is in event_time_offset and one after where the time is in tof.
If a user then wants to run a time-of-flight calibration, they will have to load in the first of these SciTiffs, as we can't go back from tof to event_time_offset again.

[YooSunYoung]

So maybe the generic t name, which would fit all of toa, tof and event_time_offset is better?
Maybe the renaming of coordinates/dimensions should be handled in the reduction software and scitiff should just use a generic t everywhere?

I'm with this opinion.
We might also have all those t related coordinates, like toa, tof, wavelength, in the t dimension.

Also, dimension names are mostly for the order of the dimension of HyperStack so that ImageJ can understand.
So it'd be easier if the dimension names are same as ImageJ.

We will just have to look at the coordinate names to see what they are and rename the dimension if needed.