Skip to content

Implement all requested actor-session fixes: fail-closed legacy migration provenance, restore GoalSessionExecutor::new source compatibility with a separate validated path, and serialize only tracing-s #5011

Description

@rysweet

Task Description

Implement all requested actor-session fixes: fail-closed legacy migration provenance, restore GoalSessionExecutor::new source compatibility with a separate validated path, and serialize only tracing-sensitive actor-scope telemetry tests. Preserve existing API/test guarantees. Do not add documentation or commit changes; validate exactly as requested by the user.

Requirements

Final Requirements

No blocking ambiguity remains. Apply these decisions:

  1. Legacy provenance: Migrate only records with explicit provenance that can be deterministically recomputed and verified. Missing, malformed, unsupported, or mismatched provenance must abort migration transactionally; never synthesize trust.
  2. Constructor compatibility: Restore GoalSessionExecutor::new(...) -> Self with its prior signature and behavior. Execution-time actor-session validation remains mandatory.
  3. Validated construction: Add GoalSessionExecutor::new_validated(...) -> Result<Self, CycleError> for immediate rejection of invalid actor-session evidence. Update only callers/tests requiring construction-time validation.
  4. Telemetry isolation: Use one shared serial_test key only on actor-scope tests that install or capture process-global tracing subscribers. Leave all unrelated telemetry and actor-session tests parallel.
  5. Preservation: Maintain existing public API behavior, security checks, error semantics, and test guarantees outside these targeted changes.
  6. Validation scope: Run only the targeted test binaries:
    • typed_ooda_actor_session_scope
    • typed_ooda_goal_session_workflow
    • typed_ooda_security_regressions
  7. Repository constraints: Make no documentation changes, dependency upgrades, unrelated refactors, or commits.

Rationale: Transactional rejection is the strongest fail-closed migration behavior; a separately named validated constructor preserves source compatibility without weakening runtime security; narrow serialization isolates only shared tracing state.

Acceptance Criteria

  • All explicit requirements met
  • Tests passing
  • Philosophy compliant
  • Documentation updated

Classification

Generated via default-workflow recipe

Metadata

Metadata

Assignees

No one assigned

    Labels

    workflow:defaultCreated by default-workflow recipe

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions