Implement all Step 11b review feedback in the current rysweet/Simard working tree: authenticated actor identity routing with trusted no-identity default and unresolved identity rejection; complete rep

[rysweet]

Task Description

Implement all Step 11b review feedback in the current rysweet/Simard working tree: authenticated actor identity routing with trusted no-identity default and unresolved identity rejection; complete repository authority enforcement and dispatch-time revalidation; centralized redacted resolver-failure telemetry and tests; correct scope API documentation and stale test names; explicit cleanup failure handling; minimally consolidate six-field scope invariants; avoid broad decomposition/file-size refactors; run targeted and appropriate release validation. Preserve existing user changes and output a complete implementation.

Requirements

Final Requirements for Design

No blocking ambiguity remains. Apply these decisions:

1. Model identity outcomes explicitly:

   • Verified identity: route using its verified actor name.
   • Trusted absence: use the documented default actor.
   • Supplied but unresolved/unverified identity: reject fail-closed.

2. Enforce repository authority against normalized repository references:

   • During initial request/session handling.
   • Immediately before every side-effecting dispatch using current authority.
   • Reject dispatch if authority was revoked or changed.

3. Centralize resolver-failure telemetry:

   • Emit only fixed event and diagnostic-classification fields.
   • Never include raw identity, repository, credential, token, path, secret, or exception text.
   • Test both classification and prohibited-data absence.

4. Surface cleanup failures through the existing tracing::warn!-based error-reporting convention. Cleanup failure must remain observable and must not be reported as successful cleanup.

5. Consolidate the six-field scope invariant surgically through ActorScopeKey or one shared comparison/validation path. Preserve public behavior and avoid broader restructuring.

6. Correct scope documentation to describe APIs and semantics that actually exist. Rename affected tests so names match their assertions.

7. Add focused coverage for:

   • Verified actor routing.
   • Trusted no-identity defaulting.
   • Unresolved supplied-identity rejection.
   • Initial repository denial.
   • Dispatch-time denial and authority revocation.
   • Redacted centralized telemetry.
   • Cleanup-failure reporting.
   • Shared six-field scope behavior.

8. Preserve all staged and unstaged user changes. Do not perform broad decomposition, file-size refactoring, dependency upgrades, or unrelated cleanup.

9. Validate in this order:

   • Affected targeted tests.
   • Full applicable locked test suite.
   • Formatting check.
   • Release builds.
   • Repository-required lint and type-check/Clippy configurations.

These requirements are complete and ready for the design phase.

Acceptance Criteria

• All explicit requirements met
• Tests passing
• Philosophy compliant
• Documentation updated

Classification

Generated via default-workflow recipe