[coverage-audit] Acceptance anchor — Simard test coverage ≥70% (per-group), whole-audit DONE gate

[rysweet]

This issue is the machine-checkable finish line for the goal audit-simard-s-test-coverage-and-raise-it-to-70-4d27c91a ("Audit Simard's test coverage and raise it to >70% line coverage").

It is CLOSED only when every box below is checked, and it must be closed by the final audit-complete pull request (Closes #4616), so the goal's completion gate observes both a merged PR and a closed issue on the same merge.

Canonical criteria: Specs/COVERAGE_AUDIT.md §2 (done) and §3 (deterministic next-target procedure). Companion ledger: docs/testing/COVERAGE_BASELINE.md.

Reproduce (the evidence — §3.1)

cargo llvm-cov --no-fail-fast --summary-only

Close-when — all must hold (§2)

• Every group in docs/testing/COVERAGE_BASELINE.md shows a landed post-lift aggregate ≥ 70% line coverage (or a recorded, justified exception).
• The ledger's "Other groups" backlog table is empty (every tracked group has landed or is explicitly deferred with justification).
• The §3 deterministic scan finds no un-ledgered src/ file that is both high-risk (per the §3 risk list) and below 70% with more than 50 executable lines.
• The measured cargo llvm-cov table proving the above is attached to the closing PR, and the ledger records the whole-audit DONE verdict.
• A test-quality audit has been completed: tautological, assertion-free, over-mocked, or trivially-passing tests in the attacked groups are fixed or removed (no coverage-padding).

Scope

The simard crate + sibling simard-* crates in rysweet/Simard only (§1). amplihack-rs (#1735 / #1937) is a different repository and out of scope. Do not convert .github/workflows/coverage.yml into a blocking CI gate (§4).

---

Filed as the acceptance-anchor done-gate during Overseer escalation triage of the stalled coverage goal (see prompt_assets/simard/overseer/escalation_triage.md). Closing this issue by hand does not complete the goal — it must be closed by the merged audit-complete PR so the completion gate certifies it.

[rysweet]

Filed during Overseer escalation triage of goal audit-simard-s-test-coverage-and-raise-it-to-70-4d27c91a (decision: rewrite-done-gate). The CLI to bind this anchor as a goal wip_ref is added in #4620 (simard goal wip add|remove|list).

Note: this issue must be closed by the final audit-complete PR (Closes #4616) — not by hand — so the completion gate observes a merged PR and a closed issue together. See Specs/COVERAGE_AUDIT.md §2/§3 for the ratified done-criteria.

[rysweet]

Overseer escalation triage — decision recorded (2026-07-25)

Triaged per prompt_assets/simard/overseer/escalation_triage.md. Blocker outcome 019f6c08 (goal audit-simard-s-test-coverage-and-raise-it-to-70-4d27c91a).

What was wrong, in plain English: Simard had no automatic way to tell this goal was finished, so it kept re-checking it every cycle without ever declaring it complete. Separately, the goal has fallen off Simard's authoritative active goal board (it lives only in the observation snapshot), so it re-alerts but the daemon can't attach a worker or finish-line to it on its own.

Decision: rewrite-done-gate. This issue (#4616) is the rewritten, machine-checkable finish line — it encodes Specs/COVERAGE_AUDIT.md §2/§3 (per-group ≥70%, empty backlog, clean §3 high-risk scan, attached cargo llvm-cov table) and is closed by the final audit-complete PR so the completion gate certifies both a merged PR and a closed issue on the same merge.

Why not complete-delivered-goal: every named per-group target has already landed ≥70% and the "Other groups" backlog is empty, but no single merged PR asserts the whole-audit §2 verdict, so there is nothing already-delivered to simply mark complete. The work is largely done; it just could never self-certify because no daemon-observable finish line was ever bound to it.

Escalation — one operator question: because the goal has dropped off the authoritative board, whether to resume it or retire it is a genuine human scope call:

Should Simard put this coverage goal back on its active list (tied to this #4616 checklist) so it finishes and certifies it — or retire it as already handled?

This question was also sent to the operator over Signal in plain English. Binding tooling is ready (simard goal wip <goal-id> add issue 4616 …, PR #4620) so that if the answer is "resume", the goal can be attached to this anchor immediately.