PR Submission Guidelines #5267
Closed
tgross35
announced in
Announcements
Replies: 1 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
When you submit a PR, please follow these guidelines to give your PR the best chance of being accepted:
All new API should be added to
libc-test/semver, which makes sure it doesn't get removed in the future.All changes must have permalink to headers in commit messages. See Source links below for more details.
For any constants that are expected to change, e.g.
*LASTor*MAX, try to add the following doc comment:Tested locally (
cd libc-test && cargo test --target mytarget) especially relevant for platforms that may not be checked in CISource links
Please include permalinks to headers in commit messages for all API changes. Common sources include:
After navigating to the relevant file, click the triple dots and select "copy permalink" if on GitHub, or l-r (links->commit) for the Android source to get a link to the current version of the header.
If sources are closed, link to documentation or paste relevant C definitions.
(The PR description is fine too, commit messages are preferred because they become part of history)
All reactions