Fix IndexMatchedPath callback to not panic on empty pathspec#1273
Open
ehuss wants to merge 1 commit into
Open
Conversation
When given an empty set of pathspecs or a set with an empty string is used, the matched pathspec in the IndexMatchedPath ends up being null. Instead of panicking, use an empty slice to mean the "all" pathspec. git has forbidden empty pathspecs since 2.16 (from 2018), but it looks like libgit2 hasn't followed that change. One could argue that getting an empty pathspec isn't quite the same as an empty set of pathspecs, but since they are treated the same (and you can't distinguish between them), it seems reasonable to me to just use an empty slice to mean the same. The main risk is if libgit2 ever decides that the empty string is no longer allowed, but an empty set is. I'm not sure if that would ever happen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When given an empty set of pathspecs or a set with an empty string is used, the matched pathspec in the IndexMatchedPath ends up being null. Instead of panicking, use an empty slice to mean the "all" pathspec.
git has forbidden empty pathspecs since 2.16 (from 2018), but it looks like libgit2 hasn't followed that change.
One could argue that getting an empty pathspec isn't quite the same as an empty set of pathspecs, but since they are treated the same (and you can't distinguish between them), it seems reasonable to me to just use an empty slice to mean the same.
The main risk is if libgit2 ever decides that the empty string is no longer allowed, but an empty set is. I'm not sure if that would ever happen.