Skip to content

Smarter path label flooding avoidance #39

Description

@diasdavid and I have a little service running that we instrument with epimetheus. There's two little issues:

  • Every possible request coming from the internet is counted, e.g. path="/phpmyadmin" or path="/wp-login.php"
  • We have only one route, which is at the root and parameterized (/{email}). Every possible parameter is counted, e.g. path="/david@example.com" and path="/lars@example.com".

I'd propose using request.route.path instead of the actual path, which would end up as e.g. a path="/{email}" label. If the route is undefined, we'd fall back to path="".

We're using HAPI here, and I'm not sure whether the other server libraries expose the route of a request.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions