From 83dd749a5162513c89906fb60f4c8d6332c66a93 Mon Sep 17 00:00:00 2001 From: ripytide Date: Mon, 26 Jan 2026 16:45:21 +0000 Subject: [PATCH 1/3] don't use sudo for any flatpak commands --- src/backends/flatpak.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/backends/flatpak.rs b/src/backends/flatpak.rs index 2cab39e..72eac2b 100644 --- a/src/backends/flatpak.rs +++ b/src/backends/flatpak.rs @@ -206,7 +206,7 @@ impl Backend for Flatpak { fn get_installed_repos(_: &Self::Config) -> Result> { let repos = run_command_for_stdout( ["flatpak", "remotes", "--columns", "options,name,url"], - Perms::Sudo, + Perms::Same, StdErr::Show, )?; @@ -255,7 +255,7 @@ impl Backend for Flatpak { .ok_or(eyre!("flatpak repos must have the \"url\" option set"))? .to_string(), ]), - Perms::Sudo, + Perms::Same, )? } @@ -279,7 +279,7 @@ impl Backend for Flatpak { x => Some(format!("--installation={x}")), }) .chain([name.to_string()]), - Perms::Sudo, + Perms::Same, )? } From 867bd36768b1aecd4c9adf1bfd3b180153af3cdd Mon Sep 17 00:00:00 2001 From: ripytide Date: Mon, 26 Jan 2026 16:48:57 +0000 Subject: [PATCH 2/3] filter out empty lines when there are no remotes --- src/backends/flatpak.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/backends/flatpak.rs b/src/backends/flatpak.rs index 72eac2b..d084553 100644 --- a/src/backends/flatpak.rs +++ b/src/backends/flatpak.rs @@ -212,6 +212,9 @@ impl Backend for Flatpak { let repos = repos .lines() + // if there are no remotes an empty line is still returned + // so we filter out empty lines + .filter(|x| !x.is_empty()) .map(|line| { let parts = line.split_whitespace().collect::>(); let installation = parts[0].split(",").collect::>()[0]; From d036489223f0cccb151ea2d61494b779274cb0e5 Mon Sep 17 00:00:00 2001 From: ripytide Date: Mon, 26 Jan 2026 16:49:17 +0000 Subject: [PATCH 3/3] remote stray dbg --- src/backends/yarn.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/backends/yarn.rs b/src/backends/yarn.rs index 924a5c0..3a09517 100644 --- a/src/backends/yarn.rs +++ b/src/backends/yarn.rs @@ -60,7 +60,6 @@ impl Backend for Yarn { let package_file = Path::new(&dir).join("package.json"); if !package_file.exists() { - dbg!(&package_file); return Ok(BTreeMap::new()); }