Skip to content

Deprecate @esbuild-plugins/node-modules-polyfill & @esbuild-plugins/node-globals-polyfill #41

Description

@mrienstra

Proposal: mark @esbuild-plugins/node-modules-polyfill & @esbuild-plugins/node-globals-polyfill as deprecated both in the README and in the npm registry (docs).

Rational:

  1. They are already listed as "out of date" in the README (as of 8fef802), and a potential replacement (esbuild-plugin-polyfill-node) is given.
  2. @esbuild-plugins/node-modules-polyfill depends on the unmaintained rollup-plugin-node-polyfills which depends on the deprecated rollup-plugin-inject.
  3. A deprecation notice might be a good way to deter the impressive cavalcade of PRs attempting to resolve the reliance on rollup-plugin-node-polyfills! (I'm being a bit silly, but in all seriousness, it might save people the trouble of working on a PR which will very likely not be merged)

Speaking of potential replacements: would it make sense to additionally mention esbuild-plugins-node-modules-polyfill?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions