Invalid meta.last on empty items

[lcarva]

If there are no builds, the last attribute of meta points to an invalid URL:

🐚  curl http://localhost:8080/api/v1/builds
{
  "items": [], 
  "meta": {
    "first": "http://localhost:8080/api/v1/builds?page=1&per_page=20", 
    "last": "http://localhost:8080/api/v1/builds?page=0&per_page=20", 
    "next": null, 
    "page": 1, 
    "pages": 0, 
    "per_page": 20, 
    "previous": null, 
    "total": 0
  }
}

🐚  curl 'http://localhost:8080/api/v1/builds?page=0&per_page=20"'
{
  "error": "The requested resource was not found"
}

meta.last should have the same value as meta.first if there are not builds.

[yashvardhannanavati]

/fs-triage

[fullsend-ai-triage]

Triage Summary

Severity: Low | Category: Bug

Problem

When a paginated API endpoint returns zero items, meta.last points to page=0, which is an invalid page number and returns a 404 when followed. The meta.last value should match meta.first (i.e., page=1) for empty collections.

Root Cause

In iib/web/utils.py, the pagination_metadata() function sets the last URL to page=pagination_query.pages. When the total item count is 0, .pages evaluates to 0, producing an invalid URL.

Recommended Fix

Clamp the page number for meta.last to a minimum of 1:

page=max(1, pagination_query.pages)

Proposed Test Case

def test_pagination_metadata_empty_results():
    """Verify meta.last is valid when there are no items."""
    # Setup: ensure no builds exist in the database
    # Action: GET /api/v1/builds
    # Assert: response['meta']['last'] contains 'page=1'
    # Assert: response['meta']['last'] == response['meta']['first']
    # Assert: following the meta.last URL returns HTTP 200

This looks like a good first issue — the fix is a one-line change with a clear test case.

---

Labels: This is a straightforward bug well-suited for newcomers, affecting the API pagination logic.

[yashvardhannanavati]

/fs-code