Skip to content

derive capabilities version from client version #90

@adietish

Description

@adietish

The client reports client capabilities protocol version. See here: https://github.com/redhat-developer/rsp-client/blob/master/src/client.ts#L116

export class RSPClient {
    ...
    /**
     * Returns the capabilities implemented by the client
     */
    getCapabilities(): Protocol.ClientCapabilitiesRequest {
        return {map: {'protocol.version': '0.16.0', 'prompt.string': 'true'}};
    }

This version should match the client/protocol version and tends to be forgotten when bumping the client version. We thus should find a way to derive this version from the client version.
A suggestion is to parse package.json, extract the version and use it when building the client. See here: #87 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions