HlsPlaylistParser: replace most usage of Java APIs with kotlin equivalents#2828
Open
Luna712 wants to merge 1 commit into
Open
HlsPlaylistParser: replace most usage of Java APIs with kotlin equivalents#2828Luna712 wants to merge 1 commit into
Luna712 wants to merge 1 commit into
Conversation
…lents This does add kotlinx-io as a dependency, it is more light weight then okio, and when we migrate to ktor for example it will become an implicit dependency anyway so it should be fine to just add. Allows for more reliable and readable usage then doing some of this manually. The largest change this does is probably to change from Java UUIDs to Kotlin native Uuid, however nothing calls the overloads this changes except in this class itself. The larger breaking change will be to eventually do that in ExtractorApi as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does add kotlinx-io as a dependency, it is more light weight then okio, and when we migrate to ktor for example it will become an implicit dependency anyway so it should be fine to just add. Allows for more reliable and readable usage then doing some of this manually.
The largest change this does is probably to change from Java UUIDs to Kotlin native Uuid, however nothing calls the overloads this changes except in this class itself. The larger breaking change will be to eventually do that in ExtractorApi as well.